Node: Add XCLAIM command.
#2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
cyip10
reviewed
Aug 6, 2024
| @@ -871,6 +871,64 @@ export async function transactionTest( | |||
| ]); | |||
| baseTransaction.xdel(key9, ["0-3", "0-5"]); | |||
| responseData.push(["xdel(key9, [['0-3', '0-5']])", 1]); | |||
|
|
|||
| // key9 has one entry here: {"0-2":[["field","value2"]]} | |||
There was a problem hiding this comment.
is this comment relevant to stay in the code? or was it more used for testing?
There was a problem hiding this comment.
Yes, it is helper for us when adding tests
cyip10
approved these changes
Aug 6, 2024
GumpacG
approved these changes
Aug 6, 2024
Yury-Fridlyand
commented
Aug 6, 2024
Co-authored-by: Guian Gumpac <guian.gumpac@improving.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…7-XCLAIM Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
yipin-chen
approved these changes
Aug 6, 2024
|
I set a reminder in my head, hope it won't GC'd. |
acarbonetto
approved these changes
Aug 7, 2024
GumpacG
added a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Aug 7, 2024
* Add `XCLAIM` command. --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Aug 12, 2024
* Add `XCLAIM` command. --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Guian Gumpac <guian.gumpac@improving.com> Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.