Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: Add HRANDFIELD command. #2096

Merged

Conversation

Yury-Fridlyand
Copy link
Collaborator

No description provided.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner August 6, 2024 22:53
Copy link
Collaborator

@GumpacG GumpacG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add transaction tests too.

node/src/BaseClient.ts Show resolved Hide resolved
node/src/BaseClient.ts Show resolved Hide resolved
@Yury-Fridlyand
Copy link
Collaborator Author

Added, thanks

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
@Yury-Fridlyand Yury-Fridlyand merged commit 2254101 into valkey-io:main Aug 7, 2024
12 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the node/yuryf-valkey-79-hrandfield branch August 7, 2024 17:07
GumpacG pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Aug 7, 2024
* Add `HRANDFIELD` command.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Aug 12, 2024
* Add `HRANDFIELD` command.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants