Node: Add XAUTOCLAIM command.
#2108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
acarbonetto
approved these changes
Aug 9, 2024
node/src/BaseClient.ts
Outdated
| * @param start - Filters the claimed entries to those that have an ID equal or greater than the | ||
| * specified value. | ||
| * @param count - (Optional) Limits the number of claimed entries to the specified value. | ||
| * @returns An `array` containing the following elements: |
There was a problem hiding this comment.
Suggested change
| * @returns An `array` containing the following elements: | |
| * @returns An array containing the following elements: |
| @@ -1051,7 +1062,7 @@ export async function transactionTest( | |||
| baseTransaction.bitpos(key17, 1); | |||
| responseData.push(["bitpos(key17, 1)", 1]); | |||
|
|
|||
| if (gte("6.0.0", version)) { | |||
| if (gte(version, "6.0.0")) { | |||
There was a problem hiding this comment.
we don't support anything less than 6...
There was a problem hiding this comment.
At least we should properly check the version, otherwise it is never tested
yipin-chen
approved these changes
Aug 9, 2024
…im-valkey-83 Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.