Node: Add XINFO GROUPS command.
#2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
GumpacG
approved these changes
Aug 13, 2024
acarbonetto
approved these changes
Aug 13, 2024
| GeoSearchResultOptions, | ||
| GeoSearchShape, | ||
| GeoSearchStoreResultOptions, | ||
| GeoUnit, | ||
| GeospatialData, | ||
| InsertPosition, | ||
| KeyWeight, // eslint-disable-line @typescript-eslint/no-unused-vars |
There was a problem hiding this comment.
confirm that this should be removed?
There was a problem hiding this comment.
We need to suppress this eslint check if we import a type to refer in docs. KeyWeight is used as a function argument, so we can remove it.
| @@ -5076,7 +5076,6 @@ export function runBaseTests<Context>(config: { | |||
| "last-entry": (string | number | string[])[]; | |||
| groups: number; | |||
| }; | |||
| console.log(result); | |||
yipin-chen
approved these changes
Aug 13, 2024
acarbonetto
reviewed
Aug 14, 2024
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.