Node: Add XREVRANGE command #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Louie <jonathanl@bitquilltech.com>
Signed-off-by: Jonathan Louie <jonathanl@bitquilltech.com>
Signed-off-by: Jonathan Louie <jonathanl@bitquilltech.com>
Yury-Fridlyand
approved these changes
Aug 17, 2024
node/src/BaseClient.ts
Outdated
| @@ -3104,6 +3105,46 @@ export class BaseClient { | |||
| return this.createWritePromise(createXRange(key, start, end, count)); | |||
| } | |||
|
|
|||
| /** | |||
| * Returns stream entries matching a given range of entry IDs in reverse order. Equivalent to `XRANGE` but returns the | |||
There was a problem hiding this comment.
nit
Suggested change
| * Returns stream entries matching a given range of entry IDs in reverse order. Equivalent to `XRANGE` but returns the | |
| * Returns stream entries matching a given range of entry IDs in reverse order. Equivalent to {@link xrange} but returns the |
Signed-off-by: Jonathan Louie <jonathanl@bitquilltech.com>
Signed-off-by: Jonathan Louie <jonathanl@bitquilltech.com>
yipin-chen
approved these changes
Aug 19, 2024
Signed-off-by: Jonathan Louie <jonathanl@bitquilltech.com>
Signed-off-by: jonathanl-bq <72158117+jonathanl-bq@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://valkey.io/commands/xrevrange/