Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: Add Binary support for stream commands, part 1 #2200

Merged
merged 5 commits into from
Aug 29, 2024
Merged

Node: Add Binary support for stream commands, part 1 #2200

merged 5 commits into from
Aug 29, 2024

Conversation

tjzhang-BQ
Copy link
Collaborator

@tjzhang-BQ tjzhang-BQ commented Aug 26, 2024 •
edited
Loading

commands included:

  • XACK
  • XADD
  • XAUTOCLAIM
  • XCLAIM
  • XDEL
  • XGROUP CREATE
  • XGROUP CREATECONSUMER
  • XGROUP DELCONSUMER
  • XGROUP DESTROY
  • XGROUP SETID

@tjzhang-BQ tjzhang-BQ force-pushed the node/integ-tjzs-VALKEY-270-stream-commands branch 2 times, most recently from 696950f to 852a965 Compare August 27, 2024 05:37
@tjzhang-BQ tjzhang-BQ marked this pull request as ready for review August 27, 2024 16:55
@tjzhang-BQ tjzhang-BQ requested a review from a team as a code owner August 27, 2024 16:55
yipin-chen
yipin-chen reviewed Aug 27, 2024
View reviewed changes
node/src/BaseClient.ts Outdated Show resolved Hide resolved
yipin-chen
yipin-chen reviewed Aug 27, 2024
View reviewed changes
node/src/BaseClient.ts Outdated Show resolved Hide resolved
yipin-chen
yipin-chen reviewed Aug 27, 2024
View reviewed changes
node/src/BaseClient.ts Outdated Show resolved Hide resolved
Yury-Fridlyand
Yury-Fridlyand reviewed Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog entry

node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
Yury-Fridlyand
Yury-Fridlyand reviewed Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please list updated commands in the PR description

node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
yipin-chen
yipin-chen approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@yipin-chen yipin-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just update documentation based on Yury's comments.

@tjzhang-BQ tjzhang-BQ force-pushed the node/integ-tjzs-VALKEY-270-stream-commands branch 2 times, most recently from b2c0ae3 to a73cfae Compare August 28, 2024 18:19
Yury-Fridlyand
Yury-Fridlyand reviewed Aug 28, 2024
View reviewed changes
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
TJ Zhang added 4 commits August 28, 2024 13:58
Node: Add Binary support for stream commands, part 1
17da532 
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
doc update
de9db7c 
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
address comments
63f9f3d 
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
address comments
70023a7 
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
@tjzhang-BQ tjzhang-BQ force-pushed the node/integ-tjzs-VALKEY-270-stream-commands branch from a73cfae to 70023a7 Compare August 28, 2024 20:59
Yury-Fridlyand
Yury-Fridlyand approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog?

changelog
fc11b5d 
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
@Yury-Fridlyand Yury-Fridlyand merged commit 8d482be into valkey-io:main Aug 29, 2024
9 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the node/integ-tjzs-VALKEY-270-stream-commands branch August 29, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@yipin-chen yipin-chen yipin-chen approved these changes

Assignees
No one assigned
Labels
node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjzhang-BQ @Yury-Fridlyand @yipin-chen