Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: Add SCRIPT commands #2267

Merged
merged 5 commits into from
Sep 11, 2024
Merged

Node: Add SCRIPT commands #2267

merged 5 commits into from
Sep 11, 2024

Conversation

yipin-chen
Copy link
Collaborator

  • Add SCRIPT EXISTS, SCRIPT KILL, and SCRIPT FLUSH commands

@yipin-chen
Node: Add SCRIPT commands
6da6289 
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
@yipin-chen
Update CHANGELOG
e0f98d3 
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
@yipin-chen
Merge branch 'main' into node/integ_yipin_script
bebc1b5
@yipin-chen
Fix lint errors
81d47be 
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
@yipin-chen
Fix unused ReadFrom
895a89d 
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
@yipin-chen yipin-chen marked this pull request as ready for review September 10, 2024 23:02
@yipin-chen yipin-chen requested a review from a team as a code owner September 10, 2024 23:02
@Yury-Fridlyand Yury-Fridlyand removed their request for review September 11, 2024 00:08
acarbonetto
acarbonetto approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@acarbonetto acarbonetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yipin-chen yipin-chen merged commit 9afe97e into valkey-io:main Sep 11, 2024
15 checks passed
@yipin-chen yipin-chen deleted the node/integ_yipin_script branch September 11, 2024 22:17
@acarbonetto acarbonetto mentioned this pull request Sep 14, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GumpacG GumpacG GumpacG approved these changes

@acarbonetto acarbonetto acarbonetto approved these changes

@tjzhang-BQ tjzhang-BQ Awaiting requested review from tjzhang-BQ

Assignees
No one assigned
Labels
node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yipin-chen @GumpacG @acarbonetto