Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: update INFO command #2274

Merged
merged 6 commits into from
Sep 11, 2024
Merged

Java: update INFO command #2274

merged 6 commits into from
Sep 11, 2024

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Sep 11, 2024 •
edited
Loading

  1. Update doc
  2. Update API to ease use (see updated docs) - breaking change

@Yury-Fridlyand Yury-Fridlyand added the java issues and fixes related to the java client label Sep 11, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner September 11, 2024 15:48
acarbonetto
acarbonetto approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@acarbonetto acarbonetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment to the PR description to state that this is a breaking change

@Yury-Fridlyand Yury-Fridlyand added the breaking breaking changes label Sep 11, 2024
@Yury-Fridlyand
Merge branch 'main' into java/yuryf-info-sections
184b30d 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand merged commit e419229 into valkey-io:main Sep 11, 2024
13 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the java/yuryf-info-sections branch September 11, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acarbonetto acarbonetto acarbonetto approved these changes

@yipin-chen yipin-chen yipin-chen approved these changes

Assignees
No one assigned
Labels
breaking breaking changes java issues and fixes related to the java client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yury-Fridlyand @acarbonetto @yipin-chen