Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get valkey/redis version using client's info command #2276

Merged

Conversation

prateek-kumar-improving
Copy link
Collaborator

Used cli commands to get valkey/redis vesion.

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
utils/TestUtils.ts Fixed Show fixed Hide fixed
utils/TestUtils.ts Fixed Show fixed Hide fixed
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
utils/TestUtils.ts Fixed Show fixed Hide fixed
utils/TestUtils.ts Fixed Show fixed Hide fixed
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
utils/TestUtils.ts Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
utils/TestUtils.ts Outdated Show resolved Hide resolved
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: prateek-kumar-improving <prateek.kumar@improving.com>
Signed-off-by: prateek-kumar-improving <prateek.kumar@improving.com>
node/tests/GlideClient.test.ts Outdated Show resolved Hide resolved
node/tests/GlideClient.test.ts Outdated Show resolved Hide resolved
node/tests/GlideClient.test.ts Outdated Show resolved Hide resolved
node/tests/GlideClusterClient.test.ts Outdated Show resolved Hide resolved
node/tests/GlideClusterClient.test.ts Outdated Show resolved Hide resolved
node/tests/PubSub.test.ts Outdated Show resolved Hide resolved
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@prateek-kumar-improving prateek-kumar-improving changed the title Get valkey/redis version using cli command Get valkey/redis version using client's info command Sep 12, 2024
utils/TestUtils.ts Outdated Show resolved Hide resolved
utils/TestUtils.ts Outdated Show resolved Hide resolved
utils/TestUtils.ts Outdated Show resolved Hide resolved
node/tests/GlideClusterClient.test.ts Outdated Show resolved Hide resolved
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

utils/TestUtils.ts Outdated Show resolved Hide resolved
utils/TestUtils.ts Outdated Show resolved Hide resolved
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if all CI pass

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@Yury-Fridlyand Yury-Fridlyand merged commit f9cfe77 into valkey-io:main Sep 13, 2024
15 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the node-get-version-using-cli-command branch September 13, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants