Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add node REPL #2355

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Add node REPL #2355

merged 2 commits into from
Oct 29, 2024

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Sep 26, 2024 •
edited
Loading

@Yury-Fridlyand
Add node REPL
a5e0053 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand added node Node.js wrapper docs Documentation labels Sep 26, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner September 26, 2024 03:25
avifenesh
avifenesh approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@avifenesh avifenesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know I need to review it, anyhow, looks good.
Works with JS as well? If so, mention.

@Yury-Fridlyand
Copy link
Collaborator Author

Works with JS as well? If so, mention.

Yes, it works, added.

@Yury-Fridlyand Yury-Fridlyand changed the base branch from main to release-1.2 October 29, 2024 19:08
@Yury-Fridlyand Yury-Fridlyand merged commit 4af45f8 into valkey-io:release-1.2 Oct 29, 2024
15 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the node/yuryf-add-repl branch October 29, 2024 20:03
adarovadya pushed a commit to adarovadya/glide-for-redis that referenced this pull request Nov 2, 2024
@Yury-Fridlyand
Add node REPL (valkey-io#2355)
286f5d5 
* Add node REPL

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acarbonetto acarbonetto acarbonetto approved these changes

@avifenesh avifenesh avifenesh approved these changes

Assignees
No one assigned
Labels
docs Documentation node Node.js wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yury-Fridlyand @avifenesh @acarbonetto