Python: adds JSON.STRLEN, JSON.STRAPPEND commands #2372

shohamazon · 2024-09-30T14:01:25Z

replaced #1187

Yury-Fridlyand · 2024-10-08T15:52:05Z

python/python/glide/async_commands/server_modules/json.py

+        For more information about the returned type, see `TJsonResponse`.
+
+    Examples:
+        >>> from glide import json as redisJson


Suggested change

>>> from glide import json as redisJson

>>> from glide import json

remove or rename alias everywhere

Yeah you're right

acarbonetto · 2024-10-08T16:04:46Z

python/python/glide/async_commands/server_modules/json.py

+    """
+    Appends the specified `value` to the string stored at the specified `path` within the JSON document stored at `key`.
+
+    See https://redis.io/commands/json.strapped/ for more details.


Suggested change

See https://redis.io/commands/json.strapped/ for more details.

See https://redis.io/commands/json.strappend/ for more details.

acarbonetto · 2024-10-08T16:09:51Z

python/python/glide/async_commands/server_modules/json.py

+        client (TRedisClient): The Redis client to execute the command.
+        key (TEncodable): The key of the JSON document.
+        value (TEncodable): The value to append to the string. Must be wrapped with single quotes. For example, to append "foo", pass '"foo"'.
+        path (Optional[TEncodable]): The JSONPath to specify. Default is root `$`.


Suggested change

path (Optional[TEncodable]): The JSONPath to specify. Default is root `$`.

path (Optional[TEncodable]): Represents the path within the JSON document where the string value will be appended. Default is root `$`.

To be consistent. Although, this description is much too verbose. I'd prefer that we go with something concise that mirrors the command description, like:

Path within the JSON document. If not specified, the root (`$`) is used.

fixed all of them, added Default to None. since the documentation say its $ but its actually . so I better not specify whats exactly it is

python/python/glide/async_commands/server_modules/json.py

acarbonetto · 2024-10-08T16:27:54Z

python/python/glide/async_commands/server_modules/json.py

+
+    Examples:
+        >>> from glide import json as redisJson
+        >>> import json


you also have json here, and you use json.dump.

python/python/tests/tests_server_modules/test_json.py

python/python/glide/async_commands/server_modules/json.py

acarbonetto · 2024-10-25T16:50:33Z

python/python/glide/async_commands/server_modules/json.py

-        >>> from glide import json as redisJson
-        >>> import json
+        >>> from glide import json
+        >>> import json as jsonpy


I wouldn't recommend aliasing standard libraries. Users won't want to refactor their code for our client.

I will change it once I change the module name

acarbonetto · 2024-10-25T16:53:25Z

python/python/glide/async_commands/server_modules/json.py

+    return cast(
+        TJsonResponse[Optional[int]],
+        await client.custom_command(
+            ["JSON.STRLEN", key, path] if path else ["JSON.STRLEN", key]


nit: personally I don't like these shortcut forms because they're specific to python

acarbonetto

Add a CHANGELOG entry

Signed-off-by: Shoham Elias <shohame@amazon.com>

Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> Co-authored-by: jonathanl-bq <72158117+jonathanl-bq@users.noreply.github.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>

Signed-off-by: Shoham Elias <shohame@amazon.com>

--------- Signed-off-by: Shoham Elias <shohame@amazon.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com> Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> Co-authored-by: jonathanl-bq <72158117+jonathanl-bq@users.noreply.github.com>

shohamazon requested a review from a team as a code owner September 30, 2024 14:01

shohamazon temporarily deployed to AWS_ACTIONS September 30, 2024 14:01 — with GitHub Actions Inactive

shohamazon added the python Python wrapper label Sep 30, 2024

shohamazon temporarily deployed to AWS_ACTIONS September 30, 2024 14:25 — with GitHub Actions Inactive

shohamazon temporarily deployed to AWS_ACTIONS October 2, 2024 09:45 — with GitHub Actions Inactive

shohamazon requested review from Yury-Fridlyand and acarbonetto October 2, 2024 09:56

shohamazon had a problem deploying to AWS_ACTIONS October 8, 2024 12:27 — with GitHub Actions Failure

shohamazon mentioned this pull request Oct 8, 2024

Node: Add command JSON.GET and JSON.SET #2399

Closed

4 tasks

Yury-Fridlyand reviewed Oct 8, 2024

View reviewed changes

acarbonetto reviewed Oct 8, 2024

View reviewed changes

shohamazon changed the base branch from main to release-1.2 October 10, 2024 13:52

shohamazon mentioned this pull request Oct 13, 2024

Json module for Python #645

Closed

22 tasks

shohamazon force-pushed the python/json.strlen branch from b7e5396 to ad92730 Compare October 13, 2024 09:43

shohamazon had a problem deploying to AWS_ACTIONS October 13, 2024 09:43 — with GitHub Actions Failure

shohamazon had a problem deploying to AWS_ACTIONS October 13, 2024 09:57 — with GitHub Actions Failure

shohamazon force-pushed the python/json.strlen branch from ad92730 to 1ae938b Compare October 13, 2024 10:22

shohamazon had a problem deploying to AWS_ACTIONS October 13, 2024 10:22 — with GitHub Actions Failure

shohamazon requested review from Yury-Fridlyand and acarbonetto October 13, 2024 11:08

shohamazon temporarily deployed to AWS_ACTIONS October 13, 2024 15:00 — with GitHub Actions Inactive

This was referenced Oct 16, 2024

Java: add JSON.SET and JSON.GET #2462

Merged

Node: add commands JSON.GET and JSON.SET #2427

Merged

shohamazon requested a review from jamesx-improving October 16, 2024 09:05

jonathanl-bq reviewed Oct 24, 2024

View reviewed changes

python/python/tests/tests_server_modules/test_json.py Outdated Show resolved Hide resolved

acarbonetto approved these changes Oct 25, 2024

View reviewed changes

acarbonetto reviewed Oct 25, 2024

View reviewed changes

shohamazon and others added 2 commits October 27, 2024 07:59

Python: adds json string commands

f418386

Signed-off-by: Shoham Elias <shohame@amazon.com>

Apply suggestions from code review

e108939

Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> Co-authored-by: jonathanl-bq <72158117+jonathanl-bq@users.noreply.github.com> Signed-off-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>

shohamazon force-pushed the python/json.strlen branch from 479a742 to e108939 Compare October 27, 2024 08:02

shohamazon had a problem deploying to AWS_ACTIONS October 27, 2024 08:02 — with GitHub Actions Error

add changelog

39542d5

Signed-off-by: Shoham Elias <shohame@amazon.com>

shohamazon temporarily deployed to AWS_ACTIONS October 27, 2024 08:07 — with GitHub Actions Inactive

fix mypy

18aec81

Signed-off-by: Shoham Elias <shohame@amazon.com>

shohamazon temporarily deployed to AWS_ACTIONS October 27, 2024 08:17 — with GitHub Actions Inactive

shohamazon merged commit 8d09a1c into release-1.2 Oct 27, 2024
16 checks passed

shohamazon deleted the python/json.strlen branch October 27, 2024 08:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Python: adds JSON.STRLEN, JSON.STRAPPEND commands #2372

Python: adds JSON.STRLEN, JSON.STRAPPEND commands #2372

shohamazon commented Sep 30, 2024 •

edited

Loading

Yury-Fridlyand Oct 8, 2024

shohamazon Oct 8, 2024

acarbonetto Oct 8, 2024

acarbonetto Oct 8, 2024

shohamazon Oct 13, 2024

acarbonetto Oct 8, 2024

acarbonetto Oct 25, 2024

shohamazon Oct 27, 2024 •

edited

Loading

acarbonetto Oct 25, 2024

acarbonetto left a comment •

edited by shohamazon

Loading

	>>> from glide import json as redisJson
	>>> from glide import json

	See https://redis.io/commands/json.strapped/ for more details.
	See https://redis.io/commands/json.strappend/ for more details.

	path (Optional[TEncodable]): The JSONPath to specify. Default is root `$`.
	path (Optional[TEncodable]): Represents the path within the JSON document where the string value will be appended. Default is root `$`.

Python: adds JSON.STRLEN, JSON.STRAPPEND commands #2372

Python: adds JSON.STRLEN, JSON.STRAPPEND commands #2372

Conversation

shohamazon commented Sep 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shohamazon Oct 27, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acarbonetto left a comment • edited by shohamazon Loading

Choose a reason for hiding this comment

shohamazon commented Sep 30, 2024 •

edited

Loading

shohamazon Oct 27, 2024 •

edited

Loading

acarbonetto left a comment •

edited by shohamazon

Loading