Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: FT.ALIASADD, FT.ALIASDEL, FT.ALIASUPDATE #2442

Merged
merged 9 commits into from
Oct 18, 2024
Merged

Java: FT.ALIASADD, FT.ALIASDEL, FT.ALIASUPDATE #2442

merged 9 commits into from
Oct 18, 2024

Conversation

cyip10
Copy link
Collaborator

@cyip10 cyip10 commented Oct 11, 2024 •
edited
Loading

Issue link

#2428

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@cyip10 cyip10 added the java issues and fixes related to the java client label Oct 11, 2024
@cyip10 cyip10 force-pushed the java/cyip10_vss_add_del_alias branch from a6c1c5c to 1a09484 Compare October 11, 2024 23:13
@cyip10 cyip10 marked this pull request as ready for review October 11, 2024 23:13
@cyip10 cyip10 requested a review from a team as a code owner October 11, 2024 23:13
@shohamazon shohamazon changed the base branch from main to release-1.2 October 13, 2024 08:07
@acarbonetto acarbonetto changed the base branch from release-1.2 to main October 15, 2024 22:37
@acarbonetto acarbonetto changed the base branch from main to release-1.2 October 15, 2024 22:37
@acarbonetto acarbonetto force-pushed the java/cyip10_vss_add_del_alias branch 2 times, most recently from eb37871 to 1d8a86a Compare October 17, 2024 16:40
@acarbonetto acarbonetto force-pushed the java/cyip10_vss_add_del_alias branch from 9ec6772 to fbdc003 Compare October 17, 2024 16:47
Yury-Fridlyand
Yury-Fridlyand reviewed Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update pr description and changelog

java/client/src/main/java/glide/api/commands/servermodules/FT.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/commands/servermodules/FT.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/commands/servermodules/FT.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/commands/servermodules/FT.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/commands/servermodules/FT.java Outdated Show resolved Hide resolved
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Oct 17, 2024
Closed
13 tasks
@acarbonetto acarbonetto force-pushed the java/cyip10_vss_add_del_alias branch from e7d319e to 02a3989 Compare October 17, 2024 21:21
@acarbonetto
Add FT.ADDALIAS FT.DELETEALIAS
cac53f0 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
@acarbonetto
spotless
b62488d 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
@acarbonetto
Update documentation and examples
314a303 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
@acarbonetto
Update documentation and examples
1fa227a 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
@acarbonetto
Update examples
dd14033 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
@acarbonetto
Clean documentation
4227b9a 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
@acarbonetto
Update tests
765e69e 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
@acarbonetto
Fix tests
8f5d831 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
@acarbonetto acarbonetto force-pushed the java/cyip10_vss_add_del_alias branch from 09b7d54 to 8f5d831 Compare October 18, 2024 20:31
@acarbonetto
CHANGELOG
78c11dd 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
@Yury-Fridlyand Yury-Fridlyand merged commit b168972 into release-1.2 Oct 18, 2024
14 of 16 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the java/cyip10_vss_add_del_alias branch October 18, 2024 21:04
avifenesh pushed a commit to avifenesh/valkey-glide that referenced this pull request Oct 21, 2024
@cyip10 @acarbonetto @avifenesh
Java: FT.ALIASADD, FT.ALIASDEL, FT.ALIASUPDATE (valkey-io#2442)
26f1ce6 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
avifenesh pushed a commit to avifenesh/valkey-glide that referenced this pull request Oct 21, 2024
@cyip10 @acarbonetto @avifenesh
Java: FT.ALIASADD, FT.ALIASDEL, FT.ALIASUPDATE (valkey-io#2442)
0ab99f0 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Muhammad-awawdi-amazon pushed a commit to Muhammad-awawdi-amazon/valkey-glide that referenced this pull request Oct 22, 2024
@cyip10 @acarbonetto @Muhammad-awawdi-amazon
Java: FT.ALIASADD, FT.ALIASDEL, FT.ALIASUPDATE (valkey-io#2442)
05f7f68 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
cyip10 added a commit that referenced this pull request Oct 23, 2024
@cyip10 @acarbonetto
Java: FT.ALIASADD, FT.ALIASDEL, FT.ALIASUPDATE (#2442)
02a5440 
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prateek-kumar-improving prateek-kumar-improving prateek-kumar-improving approved these changes

@acarbonetto acarbonetto acarbonetto approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

Assignees
No one assigned
Labels
java issues and fixes related to the java client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cyip10 @Yury-Fridlyand @acarbonetto @prateek-kumar-improving