Java: JSON.MGET.
#2514
Open
Java: JSON.MGET.
#2514
+152
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
temporarily deployed
to
AWS_ACTIONS
GitHub Actions
Inactive
Yury-Fridlyand
temporarily deployed
to
AWS_ACTIONS
GitHub Actions
Inactive
Yury-Fridlyand
requested a deployment
to
AWS_ACTIONS
GitHub Actions
Waiting
Yury-Fridlyand
commented
Oct 24, 2024
| @@ -264,7 +264,6 @@ pub(crate) fn combine_and_sort_array_results<'a>( | |||
| for (key_indices, value) in sorting_order.into_iter().zip(values) { | |||
| match value { | |||
| Value::Array(values) => { | |||
| assert_eq!(values.len(), key_indices.len()); | |||
There was a problem hiding this comment.
This assert isn't correct, because key_indices contains argument indices, where not all args are keys. It also produces a useless message if fails:
thread '<unnamed>' panicked at glide-core/redis-rs/redis/src/cluster_routing.rs:269:17:
assertion `left == right` failed
left: 1
right: 2
stack backtrace:
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
2024-10-24T19:14:37.701195Z WARN logger_core: received error - Received connection error `redis_cluster: Unable to receive command`. Will attempt to reconnect
As an option we can restore the assert, but make it producing a meaningful error and check an extra condition shipped in ResponsePolicy::CombineArrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
#2430
Also fixes #2514
Checklist
Before submitting the PR make sure the following are checked: