Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix full matrix CI #2784

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Dec 3, 2024

Space in CONTAINER_OPTIONS was interpreted by awk as field separator and it caused CI failures:
https://github.com/valkey-io/valkey-glide/actions/runs/12148100672/job/33875834171#step:3:41

Matrix entry become broken:

host-matrix=[{"OS":"ubuntu","NAMED_OS":"linux","RUNNER":"ubuntu-24.04","ARCH":"x64","TARGET":"x86_64-unknown-linux-gnu","PACKAGE_MANAGERS":["pypi","npm","maven"],"run":"always","languages":["python","node","java","go","dotnet"]},{"OS":"ubuntu","NAMED_OS":"linux","ARCH":"x64","TARGET":"x86_64-unknown-linux-musl","RUNNER":"ubuntu-24.04","IMAGE":"node:lts-alpine","CONTAINER_OPTIONS":"--user

($1 stands for the first field, $0 for entire line)

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand added the CI/CD CI/CD related label Dec 3, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner December 3, 2024 22:48
@Yury-Fridlyand Yury-Fridlyand merged commit 4de4847 into valkey-io:release-1.2 Dec 19, 2024
56 of 58 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the ci/fix-full-matrix branch December 19, 2024 17:54
Yury-Fridlyand added a commit to Bit-Quill/valkey-glide that referenced this pull request Dec 19, 2024
Fix CI

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants