Go: Implement Pfadd, Pfcount and Select commands #2822
+238
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niharika Bhavaraju <nbhavaraju@google.com>
Signed-off-by: Niharika Bhavaraju <nbhavaraju@google.com>
janhavigupta007
approved these changes
Dec 17, 2024
Signed-off-by: Niharika Bhavaraju <nbhavaraju@google.com>
| return handleLongResponse(result) | ||
| } | ||
|
|
||
| func (client *baseClient) Select(index int64) (Result[string], error) { |
There was a problem hiding this comment.
This must be implemented in standalone client only. Cluster has no databases to switch into, so this command is no-op there.
| // HyperLogLogCommands defines an interface for the "HyperLogLog Commands" group of commands for standalone and cluster | ||
| // clients. | ||
| // | ||
| // [valkey.io]: https://valkey.io/commands/?group=string#hyperloglog |
There was a problem hiding this comment.
Please fix the link and align the doc with #2844
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing the Pfadd, Pfcount and Select commands in GO client.