Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO: Adding Route support #2836

Merged
merged 21 commits into from
Dec 24, 2024
Merged

Conversation

janhavigupta007
Copy link
Collaborator

No description provided.

Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
… into go/route

Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
@janhavigupta007 janhavigupta007 requested a review from a team as a code owner December 18, 2024 10:29
@janhavigupta007 janhavigupta007 added the go golang wrapper label Dec 18, 2024
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is red, something wrong in rust code.

I propose to split this PR into multiple parts. You can develop all together, but split later in order to keep PRs small, reviewable and contain only one feature.
0. Wait for #2803 merge and rebase
2. Add INFO command
3. Add Routes
4. Add fixes for PING

Why INFO is important? It allows you to validate how command was actually routed:

$ redis-cli info server | grep tcp_port
tcp_port:6379

With INFO you can test routing feature

go/api/base_client.go Show resolved Hide resolved
go/api/commands.go Outdated Show resolved Hide resolved
go/api/request_routing_config.go Outdated Show resolved Hide resolved
go/api/request_routing_config.go Show resolved Hide resolved
go/api/glide_cluster_client.go Outdated Show resolved Hide resolved
go/api/request_routing_config.go Outdated Show resolved Hide resolved
go/src/lib.rs Show resolved Hide resolved
@janhavigupta007
Copy link
Collaborator Author

CI is red, something wrong in rust code.

I propose to split this PR into multiple parts. You can develop all together, but split later in order to keep PRs small, reviewable and contain only one feature. 0. Wait for #2803 merge and rebase 2. Add INFO command 3. Add Routes 4. Add fixes for PING

Why INFO is important? It allows you to validate how command was actually routed:

$ redis-cli info server | grep tcp_port
tcp_port:6379

With INFO you can test routing feature

I undestand that the INFO command is more suitable for checking Route functionality. My proposal is to only include Route implementation in this PR and doing the validation via INFO and PING implementations in a separate PR to keep the changes small. Hope that's okay.

Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please make a follow up PR with info, so we can verify this feature.

go/src/lib.rs Outdated Show resolved Hide resolved
@Yury-Fridlyand
Copy link
Collaborator

Please update PR description and title

Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
@janhavigupta007 janhavigupta007 changed the title GO: Adding Route support and ping cluster command GO: Adding Route support Dec 24, 2024
@janhavigupta007 janhavigupta007 merged commit 2d78c84 into valkey-io:main Dec 24, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go golang wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants