-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GO: Adding Route support #2836
GO: Adding Route support #2836
Conversation
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
… into go/route Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is red, something wrong in rust code.
I propose to split this PR into multiple parts. You can develop all together, but split later in order to keep PRs small, reviewable and contain only one feature.
0. Wait for #2803 merge and rebase
2. Add INFO
command
3. Add Routes
4. Add fixes for PING
Why INFO
is important? It allows you to validate how command was actually routed:
$ redis-cli info server | grep tcp_port
tcp_port:6379
With INFO
you can test routing feature
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
I undestand that the |
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please make a follow up PR with info
, so we can verify this feature.
Please update PR description and title |
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
No description provided.