Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: XADD #2843

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Go: XADD #2843

wants to merge 6 commits into from

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Dec 20, 2024

#2834

TODO:

  • xadd with options

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand added the go golang wrapper label Dec 20, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner December 20, 2024 02:40
@Yury-Fridlyand Yury-Fridlyand changed the title XADD Go: XADD Dec 20, 2024
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Comment on lines +1270 to +1274
if err != nil {
return CreateNilStringResult(), err
} else {
args = append(args, optionArgs...)
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if err != nil {
return CreateNilStringResult(), err
} else {
args = append(args, optionArgs...)
}
if err != nil {
return CreateNilStringResult(), err
}
args = append(args, optionArgs...)

Else block not required.

go/api/base_client.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go golang wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants