[Merge to main] Support transactions for JSON commands #2862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yipin-chen
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
yipin-chen
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
yipin-chen
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
yipin-chen
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
* addresed comments Signed-off-by: avifenesh <aviarchi1994@gmail.com> * Go: add allow_non_covered_slots to ClusterScan and related commands Signed-off-by: avifenesh <aviarchi1994@gmail.com> * feat: Implement continuous slot scanning until next unscanned slot Signed-off-by: jhpung <jhpung.dev@gmail.com> * fix: improve slot scanning logic when address not found Signed-off-by: jhpung <jhpung.dev@gmail.com> * add allowNonCoveredSlots option to ScanOptions and update GlideClusterClient Signed-off-by: avifenesh <aviarchi1994@gmail.com> * test: add tests for GlideClusterClient scan with allowNonCoveredSlots option Signed-off-by: avifenesh <aviarchi1994@gmail.com> * refactor: enhance cluster readiness check and improve error handling in scan tests Signed-off-by: avifenesh <aviarchi1994@gmail.com> --------- Signed-off-by: avifenesh <aviarchi1994@gmail.com> Signed-off-by: jhpung <jhpung.dev@gmail.com> Co-authored-by: jhpung <jhpung.dev@gmail.com> Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
* Go: Add ZPopMin and ZPopMax Signed-off-by: TJ Zhang <tj.zhang@improving.com> Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
* Node: Add Transaction for JSON commands --------- Signed-off-by: Prateek Kumar <prateek.kumar@improving.com> Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> Signed-off-by: Jonathan Louie <Jonathan.Louie@improving.com> Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> Co-authored-by: Jonathan Louie <Jonathan.Louie@improving.com>
* Add support for JSON commands in transaction --------- Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
* Java: add transaction commands for json module --------- Signed-off-by: James Xin <james.xin@improving.com> Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
yipin-chen
force-pushed
the
merge/yipin-module-transactions
branch
from
64a5c94 to
c82ce97
Compare
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
yipin-chen
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
yipin-chen
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
yipin-chen
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
yipin-chen
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
yipin-chen
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
yipin-chen
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
yipin-chen
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
yipin-chen
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
yipin-chen
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
yipin-chen
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
yipin-chen
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
yipin-chen
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
yipin-chen
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
yipin-chen
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
yipin-chen
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
python/python/glide/async_commands/server_modules/json_transaction.py
Outdated
Show resolved
Hide resolved
| * console.log(result[1]); // Output: '{"a": 1.0, "b": 2}' - result of GlideMultiJson.get() | ||
| * ``` | ||
| */ | ||
| export class GlideMultiJson { |
There was a problem hiding this comment.
Shouldn't we align naming of the classes?
There was a problem hiding this comment.
Let's have a discussion about naming with TLV team.
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
…o/valkey-glide into merge/yipin-module-transactions
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
yipin-chen
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Failure
Yury-Fridlyand
approved these changes
Jan 2, 2025
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
yipin-chen
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Failure
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): #2683
Checklist
Before submitting the PR make sure the following are checked: