Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test with timeouts for creating the client #2868

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Muhammad-awawdi-amazon
Copy link
Collaborator

@Muhammad-awawdi-amazon Muhammad-awawdi-amazon commented Dec 25, 2024

Issue link

This Pull Request is linked to issue (URL): #2837

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

Signed-off-by: Muhammad Awawdi <mawawdi@amazon.com>
@Muhammad-awawdi-amazon
Copy link
Collaborator Author

No need to review this yet - testing in CI

Signed-off-by: Muhammad Awawdi <mawawdi@amazon.com>
@@ -785,6 +785,7 @@ export class GlideClusterClient extends BaseClient {
*
* The command will be routed to all primary nodes, unless `route` is provided.
*
* When `route` is set to `allNodes`, the `INFO` command may return partial data, as the response from each node might be incomplete due to factors like network conditions or node load. This can lead to varying results across different executions.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this happen? Does this happen when command is routed to all primaries? Does this happen with other commands? Does this happen with java client?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants