ReconnectingConnection: Use sync mutex. #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the mutex is never held across an await point, there's no need for an async mutex.
|
@shachlanAmazon Whats the benefits of moving to a sync mutex? (as it might cause issues if we'll add an await later on..) |
|
It allows us to make the (also, presumably it's cheaper to use a sync mutex, but that's not the point of the PR) |
barshaul
approved these changes
Jul 26, 2023
acarbonetto
pushed a commit
that referenced
this pull request
May 29, 2024
* Python: add OBJECT REFCOUNT command (#317) * PR suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the mutex is never held across an await point, there's no need for an async mutex.