-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
organizes documentation topics, normalizes docs headings #154
organizes documentation topics, normalizes docs headings #154
Conversation
Signed-off-by: Kyle J. Davis <kyledvs@amazon.com>
Still you like to see a 'Getting started' on the |
Very good! I'm wondering if we need that first page with just the two links "commands" and "topics". It seem like an extra step to click through, but maybe there's a usability aspect to it that I'm missing. Can we just make We can also put "getting started" near the top of that page. I'm totally open to edit the |
@zuiderkwast The
And FWIW, there is no extra clicking needed - the third picture illustrates that "Documentation" is both clickable and reveals topics and command reference by mousing over. |
Great, I'm convinced. :) |
@melroy89 Yeah, possible to add this to the page. The closest thing we have today to Gettting Started is Introduction to Valkey. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and I've tested it locally. Works great!
Just a question: Is the alphabetical list of topics is based by on the title
or the linkTitle
frontmatter value of each page? I see that about half of them start with "Valkey", for example "Valkey Replication", while the other half doesn't. What's the idea here? Should we update linkTitle
on each of them so it doesn't start with "Valkey"?
Uhm maybe for another pr. This is not what I meant. I was looking more into getting-started as in how to install Valkey on different systems and platforms. And maybe some basic setup and unit.d or systemd configurations. To well, get people started. 😊 (ow and including docker of course). All a single page and linked from the docs main page. |
I believe the getting started page is this one (with URL get-started but title Quickstart), which just links to the other one with URL quickstart and another title...) @melroy89 Can we edit the first section of topics/index.md to contain what you think are the most important links? This page was modeled after how the redis website's start page looked before Salvatore left as a maintainer, but I haven't spent much time structuring it. |
Thanks @zuiderkwast, I totally overlooked those. Thanks! @melroy89 It's also possible to add it to the |
@stockholmux Yes, please merge. @melroy89 doc repo help wanted. ;) |
Description
This supersedes PR #87
This PR puts documentation in to categories, alters the top nav to make a single documentation drop down, and normalizes the heading in the documentation pages.
Issues Resolved
n/a
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.