feat: Update the about page to include a brief history of the project. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pranav Ramesh <laphatize@protonmail.com>
stockholmux
requested changes
Apr 9, 2024
There was a problem hiding this comment.
This is fantastic work @Laphatize!
I'll accept it with the changes suggested, but if you have time convert it from an HTML file to markdown and make each sentence one line.
|
Sure, no problem. I'll make those changes. |
Signed-off-by: Pranav Ramesh <laphatize@protonmail.com>
|
Should be all taken care of. Sorry it took me so long - was swamped with homework. |
|
Congrats @Laphatize! Glad to have you as a contributor. |
stockholmux
added a commit
that referenced
this pull request
Apr 10, 2024
* adds commands to top nav (#19) Signed-off-by: Kyle J. Davis <kyledvs@amazon.com> * Add the ability to pull in docs from `valkey-doc` (#22) * adds support for pulling in valkey-docs Signed-off-by: Kyle J. Davis <kyledvs@amazon.com> * one more change to layout Signed-off-by: Kyle J. Davis <kyledvs@amazon.com> --------- Signed-off-by: Kyle J. Davis <kyledvs@amazon.com> * update code owners file (#23) Add kyle to the code owners file Signed-off-by: Kyle J. Davis <kyledvs@amazon.com> * feat: Update the about page to include a brief history of the project. (#18) * feat: Update the about page to include a brief history of the project. Signed-off-by: Pranav Ramesh <laphatize@protonmail.com> * feat: Use markdown instead of HTML & update wording of history Signed-off-by: Pranav Ramesh <laphatize@protonmail.com> --------- Signed-off-by: Pranav Ramesh <laphatize@protonmail.com> --------- Signed-off-by: Kyle J. Davis <kyledvs@amazon.com> Signed-off-by: Pranav Ramesh <laphatize@protonmail.com> Co-authored-by: Pranav Ramesh <laphatize@protonmail.com>
AMoo-Miki
pushed a commit
to AMoo-Miki/valkey-website
that referenced
this pull request
Apr 11, 2024
* adds commands to top nav (valkey-io#19) Signed-off-by: Kyle J. Davis <kyledvs@amazon.com> * Add the ability to pull in docs from `valkey-doc` (valkey-io#22) * adds support for pulling in valkey-docs Signed-off-by: Kyle J. Davis <kyledvs@amazon.com> * one more change to layout Signed-off-by: Kyle J. Davis <kyledvs@amazon.com> --------- Signed-off-by: Kyle J. Davis <kyledvs@amazon.com> * update code owners file (valkey-io#23) Add kyle to the code owners file Signed-off-by: Kyle J. Davis <kyledvs@amazon.com> * feat: Update the about page to include a brief history of the project. (valkey-io#18) * feat: Update the about page to include a brief history of the project. Signed-off-by: Pranav Ramesh <laphatize@protonmail.com> * feat: Use markdown instead of HTML & update wording of history Signed-off-by: Pranav Ramesh <laphatize@protonmail.com> --------- Signed-off-by: Pranav Ramesh <laphatize@protonmail.com> --------- Signed-off-by: Kyle J. Davis <kyledvs@amazon.com> Signed-off-by: Pranav Ramesh <laphatize@protonmail.com> Co-authored-by: Pranav Ramesh <laphatize@protonmail.com>
AMoo-Miki
pushed a commit
to AMoo-Miki/valkey-website
that referenced
this pull request
Apr 11, 2024
valkey-io#18) * feat: Update the about page to include a brief history of the project. Signed-off-by: Pranav Ramesh <laphatize@protonmail.com> * feat: Use markdown instead of HTML & update wording of history Signed-off-by: Pranav Ramesh <laphatize@protonmail.com> --------- Signed-off-by: Pranav Ramesh <laphatize@protonmail.com> (cherry picked from commit 564804a)
stockholmux
pushed a commit
that referenced
this pull request
Apr 11, 2024
#18) * feat: Update the about page to include a brief history of the project. Signed-off-by: Pranav Ramesh <laphatize@protonmail.com> * feat: Use markdown instead of HTML & update wording of history Signed-off-by: Pranav Ramesh <laphatize@protonmail.com> --------- Signed-off-by: Pranav Ramesh <laphatize@protonmail.com> (cherry picked from commit 564804a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I included a brief history of the project in the /about section of the website.
Screenshot showcasing this:
Issues Resolved
Addresses a point mentioned in #13.
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.