Docs stub page + 2 docs pages #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyle J. Davis <kyledvs@amazon.com>
AMoo-Miki
approved these changes
Apr 10, 2024
24 tasks
AMoo-Miki
pushed a commit
to AMoo-Miki/valkey-website
that referenced
this pull request
Apr 11, 2024
Signed-off-by: Kyle J. Davis <kyledvs@amazon.com>
AMoo-Miki
pushed a commit
to AMoo-Miki/valkey-website
that referenced
this pull request
Apr 11, 2024
Signed-off-by: Kyle J. Davis <kyledvs@amazon.com> (cherry picked from commit 42912af)
AMoo-Miki
pushed a commit
to AMoo-Miki/valkey-website
that referenced
this pull request
Apr 11, 2024
Signed-off-by: Kyle J. Davis <kyledvs@amazon.com> (cherry picked from commit 42912af)
stockholmux
added a commit
that referenced
this pull request
Apr 11, 2024
Signed-off-by: Kyle J. Davis <kyledvs@amazon.com> (cherry picked from commit 42912af)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why non-dynamic?
Right now docs are swiss cheese as the team works through "localizing" everything to Valkey. It would be very frustrating to see nested menu after nested menu with single items on them. Once the docs are fleshed out, it would be smart to move to a dynamic display that iterates over pages.
Issues Resolved
Related to #13
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.