-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves from Jekyll to Zola #67
Conversation
Signed-off-by: Kyle J. Davis <kyledvs@amazon.com>
Do you have a suggested way to review this? |
@madolson Yeah, there are so many deletes in this PR it makes difficult to break it down. Probably best to just look at my fork/branch. The README shows how to preview the site in total (visually it's 99% identical to the existing site except with all docs exposed). The most relevant directories are FYI - this is very much a work in progress. There are a few changes that happened while I was porting the site that I need to re-integrate and the linking needs a few tweaks. I'm having a few folks try it out and give me feedback about the DX. |
Signed-off-by: Kyle J. Davis <kyledvs@amazon.com>
Not a major issue, but it looks like we aren't rendering images correctly from docs/topics. http://127.0.0.1:1111/docs/topics/lru_comparison.png just gives a generic error. |
Ok, I clicked through all the links I could find and everything else looks good to me. |
Signed-off-by: Kyle J. Davis <kyledvs@amazon.com>
Signed-off-by: Kyle J. Davis <kyledvs@amazon.com>
Signed-off-by: Kyle J. Davis <kyledvs@amazon.com>
Signed-off-by: Kyle J. Davis <kyledvs@amazon.com>
Signed-off-by: Kyle J. Davis <kyledvs@amazon.com>
Signed-off-by: Kyle J. Davis <kyledvs@amazon.com>
Signed-off-by: Kyle J. Davis <kyledvs@amazon.com>
Signed-off-by: Kyle J. Davis <kyledvs@amazon.com>
@madolson I figured out the poor syntax highlighting. Looks like I was missing some recommended styles for the built-in syntax highlighting scheme. This also solves some weird container overflow problems. It still uses the light-on-dark (which I prefer for code blocks), but I think it's possible to make it dark-on-light if you feel strongly. |
@stockholmux That looks fine to me, the problem was the lack of padding and the weird overflowing you observed. The proposal you have LGTM. |
Signed-off-by: Kyle J. Davis <kyledvs@amazon.com>
Signed-off-by: Kyle J. Davis <kyledvs@amazon.com>
Signed-off-by: Kyle J. Davis <kyledvs@amazon.com>
Signed-off-by: Kyle J. Davis <kyledvs@amazon.com>
Signed-off-by: Kyle J. Davis <kyledvs@amazon.com>
Signed-off-by: Kyle J. Davis <kyledvs@amazon.com>
Signed-off-by: Kyle J. Davis <kyledvs@amazon.com>
Signed-off-by: Kyle J. Davis <kyledvs@amazon.com>
title: Dmitry Polyakovsky | ||
extra: | ||
photo: '/assets/media/authors/dmitrypol.jpeg' | ||
github: dmitrypol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't rendering correctly when you actually click on the author profile, it's just showing the text and not the photos. E.g. http://127.0.0.1:1111/authors/dmitrypol/
I know this is in the wrong place, I think it's an issue with the author-page template, but adding a comment is so painful in this PR 😭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I see. It should show a posts by list(https://valkey.io/authors/kyledvs/), but this is a relatively easy fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly LGTM, GitHub isn't handling this massive PR very well and would rather merge it and work incrementally on smaller diffs.
Created an issue documenting all of the files that still need to be reviewed: valkey-io/valkey-doc#91 |
@madolson when you say "would rather merge it and work incrementally on smaller diffs" are you asking me to abandon this PR and do it in multiple PRs? |
No I'm saying merge it! We can followup with anything that is missing. |
Description
This changes valkey.io from Jekyll to Zola and adds all documentation topic pages.
Sorry for the big bang there isn't a graceful way to do this in git.
Path forward to Zola in production
jekyll-version
)config.extra.review_list
array.valkey-io/valkey-doc
should be created at the same to address the content bits.Issues Resolved
Fixes #62
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.