updates async test to skip if SSL not installed #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jay Miller <kjaymiller@gmail.com>
…iller/valkey-py into jm-updates-skipif-on-async
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
=======================================
Coverage ? 75.02%
=======================================
Files ? 132
Lines ? 34352
Branches ? 0
=======================================
Hits ? 25774
Misses ? 8578
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
Hi Jay! and delete all commits except 53cd1db |
Signed-off-by: Jay Miller <kjaymiller@gmail.com>
…iller/valkey-py into jm-updates-skipif-on-async
6 tasks
|
Created new PR #36 |
ahmedsobeh
pushed a commit
that referenced
this pull request
Jul 7, 2024
Signed-off-by: Jay Miller <kjaymiller@gmail.com> ### Pull Request check-list _Please make sure to review and check all of these items:_ - [x] Do tests and lints pass with this change? - [x] Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)? - [x] Is the new or changed code fully tested? - [ ] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)? - [ ] Is there an example added to the examples folder (if applicable)? - [ ] Was the change added to CHANGES file? _NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open._ ### Description of change PR that fixes commits from #34. Creates parity in testing on the sync/async tests of the connection pool by skipping the ssl tests if ssl is not installed on the async tests. Resolves #26 --------- Signed-off-by: Jay Miller <kjaymiller@gmail.com> Signed-off-by: Salvatore Mesoraca <salvatore.mesoraca@aiven.io> Co-authored-by: Salvatore Mesoraca <salvatore.mesoraca@aiven.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Creates parity in testing on the sync/async tests of the connection pool by skipping the ssl tests if ssl is not installed on the async tests.
Resolves #26