Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the required libvalkey-py version to 4.0.0 #73

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Update the required libvalkey-py version to 4.0.0 #73

merged 1 commit into from
Aug 12, 2024

Conversation

mkmkme
Copy link
Collaborator

@mkmkme mkmkme commented Aug 12, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Previously, the required libvalkey-py version contained "beta 1" version. Now the proper 4.0.0 was released, use it instead.

Signed-off-by: Mikhail Koviazin <mikhail.koviazin@aiven.io>
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.11%. Comparing base (0592263) to head (6b0cfcb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   75.11%   75.11%           
=======================================
  Files         132      132           
  Lines       34405    34405           
=======================================
  Hits        25845    25845           
  Misses       8560     8560           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aiven-sal aiven-sal enabled auto-merge August 12, 2024 13:50
@aiven-sal aiven-sal merged commit ff40431 into valkey-io:main Aug 12, 2024
74 checks passed
@mkmkme mkmkme deleted the mkmkme/libvalkey-4.0.0 branch August 12, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants