-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update python version constraint to < 3.11 for async-timeout requirement #87
update python version constraint to < 3.11 for async-timeout requirement #87
Conversation
1d18b16
to
d7962f0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
- Coverage 75.12% 75.12% -0.01%
==========================================
Files 132 132
Lines 34398 34398
==========================================
- Hits 25841 25840 -1
- Misses 8557 8558 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
async-timeout library has effectively been upstreamed into Python 3.11+. installing it for python >= 3.11 should not be necessary. this will enable packaging valkey-py for fedora 39, which comes with python 3.12 and does not conatin async-timeout 4.0.3 package. see the deprecation notice: https://github.com/aio-libs/async-timeout?tab=readme-ov-file#deprecated Signed-off-by: Ali Gholami <ali.gholami@aiven.io>
d7962f0
to
a315de8
Compare
Hi @ali-gholami-aiven @aiven-sal quick question about this one are we saying that, in this PR, v6.0.1 is no longer usable with Python 3.11.0? That is what I'm on rn, and bc of this block in valkey/asyncio/connection.py
this code now fails by trying to import an async_timeout that doesn't exist. Which is fine, I can upgrade all my systems up in Python version but just wanted to get a recommendation here |
Hey @nirav-ark-biotech, Hmm that sounds odd. It should be usable still. EDIT: Sorry I probably misunderstood the problem here. Could you run the python RESP and try to execute from asyncio import timeout as async_timeout ? Will this work for you? |
yeah that works I'll just pip install async timeout first, which fixes it. maybe all this codebase needs is a documentation update |
async-timeout library has effectively been upstreamed into Python 3.11+. installing it for python >= 3.11 should not be necessary.
this will enable packaging valkey-py for fedora 39, which comes with python 3.12 and does not conatin async-timeout 4.0.3 package.
see the deprecation notice:
https://github.com/aio-libs/async-timeout?tab=readme-ov-file#deprecated
Pull Request check-list
Description of change