Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] server.repl__transfer_s is double-closed/freed in fullSyncWithPrimary #1088

Closed
PingXie opened this issue Sep 29, 2024 · 0 comments · Fixed by #1097
Closed

[BUG] server.repl__transfer_s is double-closed/freed in fullSyncWithPrimary #1088

PingXie opened this issue Sep 29, 2024 · 0 comments · Fixed by #1097
Assignees
@naglera

Comments

@PingXie
Copy link
Member

PingXie commented Sep 29, 2024 

          This looks like a bug to me. It seems the two connection objects are getting mixed up. We should zero out the RDB channel connection here, i.e., `server.repl_rdb_transfer_s = NULL`. Then on L2726/L2747, we should be testing the normal channel connection instead, i.e., `if (server.repl_transfer_s)`

Originally posted by @PingXie in #945 (comment)
@PingXie PingXie mentioned this issue Sep 29, 2024
Merged
@ranshid ranshid mentioned this issue Sep 30, 2024
Merged
naglera pushed a commit to naglera/placeholderkv that referenced this issue Oct 10, 2024
@ranshid @naglera
avoid double close on replica main channel (valkey-io#1097)
6e6f9ca 
fixes valkey-io#1088

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
eifrah-aws pushed a commit to eifrah-aws/valkey that referenced this issue Oct 20, 2024
@ranshid @eifrah-aws
avoid double close on replica main channel (valkey-io#1097)
e978a01 
fixes valkey-io#1088

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naglera naglera

Labels
None yet
Projects
Valkey 8.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

avoid double close on replica main channel ranshid/valkey
2 participants
@PingXie @naglera