-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test Failure] Sync should continue if not all slaves dropped dual-channel-replication #1153
Labels
test-failure
An issue indicating a test failure
Comments
Seems the issue is related to the fact that without dual-channel the replication COB is filled up during the test, for example:
I think of 2 fixes:
@naglera WDYT? |
enjoy-binbin
added a commit
that referenced
this issue
Oct 14, 2024
…el-replication (#1164) Sometimes when dual-channel is turned off the tested replica might disconnect on COB overrun. disable the replica COB limit in order to prevent such cases. Fixes: #1153 Signed-off-by: Ran Shidlansik <ranshid@amazon.com> Signed-off-by: Binbin <binloveplay1314@qq.com> Co-authored-by: Binbin <binloveplay1314@qq.com>
eifrah-aws
pushed a commit
to eifrah-aws/valkey
that referenced
this issue
Oct 20, 2024
…el-replication (valkey-io#1164) Sometimes when dual-channel is turned off the tested replica might disconnect on COB overrun. disable the replica COB limit in order to prevent such cases. Fixes: valkey-io#1153 Signed-off-by: Ran Shidlansik <ranshid@amazon.com> Signed-off-by: Binbin <binloveplay1314@qq.com> Co-authored-by: Binbin <binloveplay1314@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sync should continue if not all slaves dropped dual-channel-replication no in tests/integration/dual-channel-replication.tcl
https://github.com/valkey-io/valkey/actions/runs/11283922852/job/31417235703#step:5:7269
Doesn't specifically look like a dual channel issue, but seems to be a test issue.
The text was updated successfully, but these errors were encountered: