-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to C11 and adopt _Atomic, static_asserts, and thread_local #485
Comments
@madolson Are we sticking to the default memory ordering for _Atomic operations (ex: incr, decr, ....) for C11 which is sequentially consistent memory ordering |
Historically we have predominantly used atomics for counters in other threads, which are fine with |
@madolson please take a look at the PR to see if it's good, so I can finish up the remaining parts |
- Replaces custom atomics logic with C11 default atomics logic. - Drops "atomicvar_api" field from server info Closes #485 --------- Signed-off-by: adetunjii <adetunjithomas1@outlook.com> Signed-off-by: Samuel Adetunji <adetunjithomas1@outlook.com> Co-authored-by: teej4y <samuel.adetunji@prunny.com>
As per 445a4b6, we implemented custom logic to compile with C11 when atomics were available, and C99 when they were not available. However, with the EoL of CentOS 7, we believe that all default compilers should be able to compile with C99. This gives us access to three pieces of functionality we use:
_thread
.This change should target Valkey 8. We will continue to use the old gcc version on Valkey 7.2.
The text was updated successfully, but these errors were encountered: