Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve stability of hostnames test #1016

Merged
merged 5 commits into from
Sep 11, 2024
Merged

Improve stability of hostnames test #1016

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
49ed444
Improve stability of hostnames test
madolson Sep 11, 2024
e4582bc
Address comment
madolson Sep 11, 2024
ada8366
Use inclusive language
madolson Sep 11, 2024
8f779ec
Change variable name
madolson Sep 11, 2024
308357d
Fix a typo
madolson Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions tests/unit/cluster/hostnames.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,11 +132,14 @@ test "Verify the nodes configured with prefer hostname only show hostname for ne
R $j config set cluster-announce-hostname "shard-$j.com"
}

# Grab the ID so we have it later for validation
set primary_id [R 0 CLUSTER MYID]

# Prevent Node 0 and Node 6 from properly meeting,
# they'll hang in the handshake phase. This allows us to
# test the case where we "know" about it but haven't
# successfully retrieved information about it yet.
R 0 DEBUG DROP-CLUSTER-PACKET-FILTER 0
pause_process [srv 0 pid]
R 6 DEBUG DROP-CLUSTER-PACKET-FILTER 0

# Have a replica meet the isolated node
Expand Down Expand Up @@ -174,12 +177,11 @@ test "Verify the nodes configured with prefer hostname only show hostname for ne

# Also make sure we know about the isolated master, we
# just can't reach it.
set master_id [R 0 CLUSTER MYID]
assert_match "*$master_id*" [R 6 CLUSTER NODES]
assert_match "*$primary_id*" [R 6 CLUSTER NODES]

# Stop dropping cluster packets, and make sure everything
# stabilizes
R 0 DEBUG DROP-CLUSTER-PACKET-FILTER -1
resume_process [srv 0 pid]
R 6 DEBUG DROP-CLUSTER-PACKET-FILTER -1

# This operation sometimes spikes to around 5 seconds to resolve the state,
Expand Down
Loading