Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid timing issue in diskless-load-swapdb test #1077

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

enjoy-binbin
Copy link
Member

Since we paused the primary node earlier, the replica may enter
cluster down due to primary node pfail. Here set allow read to
prevent subsequent read errors.

Since we paused the primary node earlier, the replica may enter
cluster down due to primary node pfail. Here set allow read to
prevent subsequent read errors.

Signed-off-by: Binbin <binloveplay1314@qq.com>
@enjoy-binbin
Copy link
Member Author

failed CI:
https://github.com/valkey-io/valkey/actions/runs/10987837289/job/30503299419#step:5:4849

[exception]: Executing test client: CLUSTERDOWN The cluster is down.
CLUSTERDOWN The cluster is down
    while executing
"$replica get $slot0_key"
    ("uplevel" body line 70)
    invoked from within
"uplevel 1 $code"
    (procedure "test" line 58)
    invoked from within
"test "Main db not affected when fail to diskless load" {

@enjoy-binbin enjoy-binbin added the test-failure An issue indicating a test failure label Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.62%. Comparing base (bf8183d) to head (dcdf581).
Report is 8 commits behind head on unstable.

Additional details and impacted files
@@            Coverage Diff            @@
##           unstable    #1077   +/-   ##
=========================================
  Coverage     70.61%   70.62%           
=========================================
  Files           114      114           
  Lines         61695    61695           
=========================================
+ Hits          43568    43573    +5     
+ Misses        18127    18122    -5     

see 11 files with indirect coverage changes

@madolson madolson merged commit 9827eef into valkey-io:unstable Oct 1, 2024
46 checks passed
@enjoy-binbin enjoy-binbin deleted the fix_timing_issue branch October 2, 2024 02:30
naglera pushed a commit to naglera/placeholderkv that referenced this pull request Oct 10, 2024
Since we paused the primary node earlier, the replica may enter
cluster down due to primary node pfail. Here set allow read to
prevent subsequent read errors.

Signed-off-by: Binbin <binloveplay1314@qq.com>
Signed-off-by: naglera <anagler123@gmail.com>
SoftlyRaining pushed a commit to SoftlyRaining/valkey that referenced this pull request Oct 11, 2024
Since we paused the primary node earlier, the replica may enter
cluster down due to primary node pfail. Here set allow read to
prevent subsequent read errors.

Signed-off-by: Binbin <binloveplay1314@qq.com>
eifrah-aws pushed a commit to eifrah-aws/valkey that referenced this pull request Oct 20, 2024
Since we paused the primary node earlier, the replica may enter
cluster down due to primary node pfail. Here set allow read to
prevent subsequent read errors.

Signed-off-by: Binbin <binloveplay1314@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-failure An issue indicating a test failure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants