Add CMake build system for valkey #1082
DCO
There are 17 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.
To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <authoremail@example.com>
in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s
).
Here is how to fix the problem so that this code can be merged.
Rebase the branch
If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").
You should only do this if:
- You are the only author of the commits in this branch
- You are absolutely certain nobody else is doing any work based upon this branch
- There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using
--allow-empty
)
To add your Signed-off-by line to every commit in this branch:
- Ensure you have a local copy of your branch by checking out the pull request locally via command line.
- In your local branch, run:
git rebase HEAD~52 --signoff
- Force push your changes to overwrite the branch:
git push --force-with-lease origin cmake
Summary
Commit sha: 9fa4ef1, Author: Masahiro Ide, Committer: Eran Ifrah; Expected "Masahiro Ide imasahiro9@gmail.com", but got "Masahiro Ide masahiro.ide@lycorp.co.jp".
Commit sha: 5d89211, Author: Nadav Levanoni, Committer: Eran Ifrah; Can not find "Nadav Levanoni 38641521+nadav-levanoni@users.noreply.github.com", in ["Nadav Levanoni nadavl@amazon.com", "Madelyn Olson madelyneolson@gmail.com"].
Commit sha: f1fbd7d, Author: otheng, Committer: Eran Ifrah; Expected "otheng qnade@naver.com", but got "otheng03 07c00h@gmail.com".
Commit sha: 7eeeb45, Author: Parth, Committer: Eran Ifrah; Expected "Parth 661497+parthpatel@users.noreply.github.com", but got "Parth Patel 661497+parthpatel@users.noreply.github.com".
Commit sha: e978a01, Author: ranshid, Committer: Eran Ifrah; Expected "ranshid 88133677+ranshid@users.noreply.github.com", but got "Ran Shidlansik ranshid@amazon.com".
Commit sha: 892fc84, Author: ranshid, Committer: Eran Ifrah; Expected "ranshid 88133677+ranshid@users.noreply.github.com", but got "Ran Shidlansik ranshid@amazon.com".
Commit sha: 41c4a32, Author: ranshid, Committer: Eran Ifrah; Can not find "ranshid 88133677+ranshid@users.noreply.github.com", in ["Ran Shidlansik ranshid@amazon.com", "Binbin binloveplay1314@qq.com"].
Commit sha: a05fc0e, Author: Romain Geissler @ Amadeus, Committer: Eran Ifrah; Expected "Romain Geissler @ Amadeus romain.geissler@amadeus.com", but got "Romain Geissler romain.geissler@amadeus.com".
Commit sha: 2389b2c, Author: Roshan Khatri, Committer: Eran Ifrah; Expected "Roshan Khatri 117414976+roshkhatri@users.noreply.github.com", but got "Roshan Khatri rvkhatri@amazon.com".
Commit sha: 81192d4, Author: Shivshankar, Committer: Eran Ifrah; Expected "Shivshankar shiva.sheri.github@gmail.com", but got "Shivshankar-Reddy shiva.sheri.github@gmail.com".
Commit sha: 7df88bc, Author: Shivshankar, Committer: Eran Ifrah; Expected "Shivshankar shiva.sheri.github@gmail.com", but got "Shivshankar-Reddy shiva.sheri.github@gmail.com".
Commit sha: 093cf10, Author: Shivshankar, Committer: Eran Ifrah; Expected "Shivshankar shiva.sheri.github@gmail.com", but got "Shivshankar-Reddy shiva.sheri.github@gmail.com".
Commit sha: 71ffb57, Author: Shivshankar, Committer: Eran Ifrah; Expected "Shivshankar shiva.sheri.github@gmail.com", but got "Shivshankar-Reddy shiva.sheri.github@gmail.com".
Commit sha: 7ea3a97, Author: Shivshankar, Committer: Eran Ifrah; Expected "Shivshankar shiva.sheri.github@gmail.com", but got "Shivshankar-Reddy shiva.sheri.github@gmail.com".
Commit sha: c86cdd6, Author: Shivshankar, Committer: Eran Ifrah; Expected "Shivshankar shiva.sheri.github@gmail.com", but got "Shivshankar-Reddy shiva.sheri.github@gmail.com".
Commit sha: 1f06a1c, Author: Shivshankar, Committer: Eran Ifrah; The sign-off is missing.
Commit sha: 9c07468, Author: Wen Hui, Committer: Eran Ifrah; Expected "Wen Hui wen.hui.ware@gmail.com", but got "hwware wen.hui.ware@gmail.com".