Introduce connection context for Unix socket #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pizhenwei
force-pushed
the
introduce-unix-connection-context
branch
2 times, most recently
from
86b62e2
to
0235b6b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1160 +/- ##
============================================
+ Coverage 70.65% 70.70% +0.05%
============================================
Files 114 114
Lines 61799 63073 +1274
============================================
+ Hits 43664 44597 +933
- Misses 18135 18476 +341
|
Hide 'unixsocketgroup' and 'unixsocketperm' into a Unix socket specific data structure. A single opaque pointer 'void *priv' is enough for a listener. Once any new config is added, we don't need 'void *priv2', 'void *priv3' and so on. Fixes: b48596a ('Add support for setting the group on a unix domain socket (valkey-io#901)') Cc: Ayush Sharma <mrayushs933@gmail.com> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
pizhenwei
force-pushed
the
introduce-unix-connection-context
branch
from
0235b6b
to
acf811f
Compare
There was a problem hiding this comment.
This was a decision made at the time (for simplicity), #901 (review)
i am ok with both, i will let @madolson do the call.
madolson
approved these changes
Oct 19, 2024
eifrah-aws
pushed a commit
to eifrah-aws/valkey
that referenced
this pull request
Oct 20, 2024
Hide 'unixsocketgroup' and 'unixsocketperm' into a Unix socket specific data structure. A single opaque pointer 'void *priv' is enough for a listener. Once any new config is added, we don't need 'void *priv2', 'void *priv3' and so on. Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide 'unixsocketgroup' and 'unixsocketperm' into a Unix socket specific data structure. A single opaque pointer 'void *priv' is enough for a listener. Once any new config is added, we don't need 'void *priv2', 'void *priv3' and so on.
Fixes: b48596a ('Add support for setting the group on a unix domain socket (#901)')
Cc: Ayush Sharma mrayushs933@gmail.com