Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit CLUSTER_CANT_FAILOVER_DATA_AGE log to 10 times period #1189

Merged
merged 3 commits into from
Oct 24, 2024

Commits on Oct 18, 2024

  1. Limit CLUSTER_CANT_FAILOVER_DATA_AGE log to 10 times period

    If a replica is step into data_age too old stage, it can not
    trigger the failover and currently it can not be automatically
    recovered and we will print a log every CLUSTER_CANT_FAILOVER_RELOG_PERIOD,
    which is every second. If the primary has not recovered or there is
    no manual failover, this log will flood the log file.
    
    In this case, limit its frequency to 10 times period, which is
    10 seconds in our code. Also in this data_age too old stage,
    the repeated logs also can stand for the progress of the failover.
    
    See also valkey-io#780 for more details about it.
    
    Signed-off-by: Binbin <binloveplay1314@qq.com>
    enjoy-binbin committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    2fb5558 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Update src/cluster_legacy.c

    Co-authored-by: Ping Xie <pingxie@outlook.com>
    Signed-off-by: Binbin <binloveplay1314@qq.com>
    enjoy-binbin and PingXie authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    901d0d7 View commit details
    Browse the repository at this point in the history
  2. fix code and format

    Signed-off-by: Binbin <binloveplay1314@qq.com>
    enjoy-binbin committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    80bd495 View commit details
    Browse the repository at this point in the history