-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CMake build system for valkey #1196
Open
eifrah-aws
wants to merge
16
commits into
valkey-io:unstable
Choose a base branch
from
eifrah-aws:cmake
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,197
−38
Commits on Oct 20, 2024
-
Signed-off-by: Eran Ifrah <eifrah@amazon.com>
Configuration menu - View commit details
-
Copy full SHA for f06b624 - Browse repository at this point
Copy the full SHA f06b624View commit details
Commits on Oct 21, 2024
-
- Force function names to lowercase in YAML config file - Parse version from version.h instead of hard-coding it - Fixed typo - Moved utility functions into their own module `Utils.cmake` - macOS: do not hard code "/usr/bin/clang", instead use `find_program` - Support for WITH_TLS=module|yes|off|1|0 - Support for WITH_RDMA=module|off|0 - Fixed (never worked for the original Makefile as well): build TLS as module on macOS Signed-off-by: Eran Ifrah <eifrah@amazon.com>
Configuration menu - View commit details
-
Copy full SHA for 9e53867 - Browse repository at this point
Copy the full SHA 9e53867View commit details
Commits on Oct 22, 2024
-
- Fixed comment - Use a more accurate variable name `RDMACM` as the output prefix - Avoid using condition like `if (USE_TLS EQUAL 2)`, instead use `if (BUILD_TLS_MODULE)` - Build "hello*" moodules - Build "test" modules (using conditional variable `-DBUILD_TEST_MODULES=1`) - Build "rdma-test" Signed-off-by: Eran Ifrah <eifrah@amazon.com>
Configuration menu - View commit details
-
Copy full SHA for 1dbc492 - Browse repository at this point
Copy the full SHA 1dbc492View commit details -
Signed-off-by: Eran Ifrah <eifrah@amazon.com>
Configuration menu - View commit details
-
Copy full SHA for 8589132 - Browse repository at this point
Copy the full SHA 8589132View commit details -
limit the "-std=gnu11" to linux only
Signed-off-by: Eran Ifrah <eifrah@amazon.com>
Configuration menu - View commit details
-
Copy full SHA for b5993a0 - Browse repository at this point
Copy the full SHA b5993a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for c64b5d8 - Browse repository at this point
Copy the full SHA c64b5d8View commit details -
Updated README to include CMake section
Signed-off-by: Eran Ifrah <eifrah@amazon.com>
Configuration menu - View commit details
-
Copy full SHA for f166512 - Browse repository at this point
Copy the full SHA f166512View commit details -
Signed-off-by: Eran Ifrah <eifrah@amazon.com>
Configuration menu - View commit details
-
Copy full SHA for 7734d9c - Browse repository at this point
Copy the full SHA 7734d9cView commit details -
Signed-off-by: Eran Ifrah <eifrah@amazon.com>
Configuration menu - View commit details
-
Copy full SHA for 9c81b77 - Browse repository at this point
Copy the full SHA 9c81b77View commit details -
Configuration menu - View commit details
-
Copy full SHA for be704ac - Browse repository at this point
Copy the full SHA be704acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5281bb2 - Browse repository at this point
Copy the full SHA 5281bb2View commit details -
- Build of the example modules is now conditional (defaults to NO) - README.md fixup - Fixed UT build (exposed VALKEY_USE_TEST_MAIN & VALKEY_USE_TEST_SERVER_ASSERT macros only for macOS) - Added missing valkeylib for UT build (which was removed previous commit) Signed-off-by: Eran Ifrah <eifrah@amazon.com>
Configuration menu - View commit details
-
Copy full SHA for f59c5fc - Browse repository at this point
Copy the full SHA f59c5fcView commit details
Commits on Oct 23, 2024
-
- Moved rdma-tests source file to their own file - Unit tests are no longer handled separately - Use CMake function `ProcessorCount` to determine the number of jobs to run when invoking `make` - FreeBSD: valkey-unit-tests: link against execinfo for backtrace symbols Signed-off-by: Eran Ifrah <eifrah@amazon.com>
Configuration menu - View commit details
-
Copy full SHA for 563358a - Browse repository at this point
Copy the full SHA 563358aView commit details
Commits on Oct 24, 2024
-
- Make `main` + `serverAssert` "weak" symbols - Set LTO using CMake proper syntax instead of hacking it into the build flags - For consistency, change all args starting with `WITH_*` to `BUILD_*`. for example: `cmake .. -DBUILD_TLS=module -DBUILD_MALLOC=jemalloc -DBUILD_UNIT_TESTS=1` - Only search for OpenSSL if BUILD_TLS is "on" or "module" Signed-off-by: Eran Ifrah <eifrah@amazon.com>
Configuration menu - View commit details
-
Copy full SHA for bfc2991 - Browse repository at this point
Copy the full SHA bfc2991View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83a5840 - Browse repository at this point
Copy the full SHA 83a5840View commit details -
Signed-off-by: Eran Ifrah <eifrah@amazon.com>
Configuration menu - View commit details
-
Copy full SHA for ec9ec96 - Browse repository at this point
Copy the full SHA ec9ec96View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.