Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating command.def by running the generate-command-code.py #1203

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

Shivshankar-Reddy
Copy link
Contributor

@Shivshankar-Reddy Shivshankar-Reddy commented Oct 21, 2024

Part of #1200 PR, since feild is changed. Looks like commands.def is missed to get genereated based on the changes so that is causing CI failure on unstable.

Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
@madolson madolson merged commit 771918e into valkey-io:unstable Oct 21, 2024
45 checks passed
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.69%. Comparing base (5885dc5) to head (384bcda).
Report is 1 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1203      +/-   ##
============================================
+ Coverage     70.58%   70.69%   +0.10%     
============================================
  Files           114      114              
  Lines         63090    63090              
============================================
+ Hits          44535    44601      +66     
+ Misses        18555    18489      -66     
Files with missing lines Coverage Δ
src/commands.def 100.00% <ø> (ø)

... and 13 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants