-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update comment in cluster_legacy.h #277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat! I believe I signed it correctly now, but am unsure how to rerun the test - is this something you do or do I need to create a new PR? |
you can see the detail git commit message in your commit, it did not signoff. you can take a look in the unstable branch commit, all commits have a |
@bentotten The easier thing you can do while on the patch-2 branch is:
If you have git setup to add your name. That will add the signoff. |
Update comment suggesting clusterMsgPingExtTypes to clusterMsgPingtypes as clusterMsgPingExtTypes does not exist. Additionally specify that ver is set to CLUSTER_PROTO_VER, not "1", to make it easier to see where to change this. Signed-off-by: Ben Totten <btotten@amazon.com>
Complete (I think) Note: additional comment improvement for |
Update comment suggesting clusterMsgPingExtTypes to clusterMsgPingtypes as clusterMsgPingExtTypes does not exist Signed-off-by: Ben Totten <btotten@amazon.com>
Update comment suggesting clusterMsgPingExtTypes to clusterMsgPingtypes as clusterMsgPingExtTypes does not exist Signed-off-by: Ben Totten <btotten@amazon.com>
Update comment suggesting clusterMsgPingExtTypes to clusterMsgPingtypes as clusterMsgPingExtTypes does not exist