Update comment in cluster_legacy.h #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neat! I believe I signed it correctly now, but am unsure how to rerun the test - is this something you do or do I need to create a new PR? |
|
you can see the detail git commit message in your commit, it did not signoff. you can take a look in the unstable branch commit, all commits have a |
|
@bentotten The easier thing you can do while on the patch-2 branch is: If you have git setup to add your name. That will add the signoff. |
Update comment suggesting clusterMsgPingExtTypes to clusterMsgPingtypes as clusterMsgPingExtTypes does not exist. Additionally specify that ver is set to CLUSTER_PROTO_VER, not "1", to make it easier to see where to change this. Signed-off-by: Ben Totten <btotten@amazon.com>
|
Complete (I think) Note: additional comment improvement for |
madolson
approved these changes
Apr 11, 2024
zuiderkwast
pushed a commit
to zuiderkwast/placeholderkv
that referenced
this pull request
Apr 17, 2024
Update comment suggesting clusterMsgPingExtTypes to clusterMsgPingtypes as clusterMsgPingExtTypes does not exist Signed-off-by: Ben Totten <btotten@amazon.com>
PatrickJS
pushed a commit
to PatrickJS/placeholderkv
that referenced
this pull request
Apr 24, 2024
Update comment suggesting clusterMsgPingExtTypes to clusterMsgPingtypes as clusterMsgPingExtTypes does not exist Signed-off-by: Ben Totten <btotten@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update comment suggesting clusterMsgPingExtTypes to clusterMsgPingtypes as clusterMsgPingExtTypes does not exist