-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the TLS and REPS issues about CLUSTER SLOTS cache #581
Fix the TLS and REPS issues about CLUSTER SLOTS cache #581
Conversation
Signed-off-by: zhaozhao.zz <zhaozhao.zz@alibaba-inc.com>
Signed-off-by: zhaozhao.zz <zhaozhao.zz@alibaba-inc.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #581 +/- ##
============================================
- Coverage 70.17% 70.00% -0.18%
============================================
Files 110 110
Lines 60077 60081 +4
============================================
- Hits 42160 42057 -103
- Misses 17917 18024 +107
|
Nice catch @soloestoy! Could we add test cases for these scenario for coverage? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I forgot that we added a map response at the end. I assumed the response would be the same.
I'm wondering now why the response framework didn't catch this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Overall.
Signed-off-by: zhaozhao.zz <zhaozhao.zz@alibaba-inc.com>
Signed-off-by: zhaozhao.zz <zhaozhao.zz@alibaba-inc.com>
PR #53 introduced the cache of CLUSTER SLOTS response, but the cache has some problems for different types of clients:
the RESP version is wrongly ignored:
RESP3 should get "empty hash" but get RESP2's "empty array"
we should use the original client's connect type, or lua/function and module would get wrong port: