Replicate slot migration states via RDB aux fields #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ping Xie <pingxie@google.com>
PingXie
force-pushed
the
repl-slot-states-in-rdb
branch
from
8ac5fee
to
97180e5
Compare
PingXie
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #586 +/- ##
============================================
- Coverage 70.20% 70.18% -0.02%
============================================
Files 110 110
Lines 60007 60042 +35
============================================
+ Hits 42130 42143 +13
- Misses 17877 17899 +22
|
Signed-off-by: Ping Xie <pingxie@google.com>
madolson
reviewed
Jun 2, 2024
…l-slot-states-in-rdb
Signed-off-by: Ping Xie <pingxie@google.com>
madolson
reviewed
Jun 3, 2024
Signed-off-by: Ping Xie <pingxie@google.com>
Signed-off-by: Ping Xie <pingxie@google.com>
Signed-off-by: Ping Xie <pingxie@google.com>
…l-slot-states-in-rdb
madolson
approved these changes
Jun 8, 2024
advaMosh
pushed a commit
to advaMosh/valkey
that referenced
this pull request
Jun 10, 2024
Signed-off-by: Adva Moshkovitz <advamo7@gmail.com>
naglera
pushed a commit
to naglera/placeholderkv
that referenced
this pull request
Jun 10, 2024
|
Aux fields are ignored when the RDB is loaded by an older version, right? We still need to do #421 for online replicas though, don't we? |
enjoy-binbin
added a commit
to enjoy-binbin/valkey
that referenced
this pull request
Jun 17, 2024
When we goto eoferr, we need to release the auxkey and auxval, this is a cleanup, also explicitly check that decoder return value is C_ERR. Introduced in valkey-io#586. Signed-off-by: Binbin <binloveplay1314@qq.com>
yes
i guess the answer is also yes. |
PingXie
pushed a commit
that referenced
this pull request
Jun 18, 2024
When we goto eoferr, we need to release the auxkey and auxval, this is a cleanup, also explicitly check that decoder return value is C_ERR. Introduced in #586. Signed-off-by: Binbin <binloveplay1314@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replicate slot migration states via RDB aux fields to eliminate the brief window of inconsistency that could break the high availability guarantee intended by #445. Previously, these states were replicated using explicit
CLUSTER SETSLOTcommands after full resync is completed, which was not only a hack but also created this window where a new replica can becomeonlinewithout knowing its primary's slot migration states.Additionally, this PR introduces a generic framework for extending RDB aux fields without strong coupling. Now other subsystems in the server, such as cluster bus, can inject aux fields into RDB without rdb.c taking a code dependency on them via hardcoded functions.
Fix #419