-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast path in SET if the expiration time is expired #865
Merged
Commits on Aug 2, 2024
-
Fast path in SET if the expiration time is expired
If the expiration time passed in SET is expired, for example, it has expired due to the machine time (DTS) or the expiration time passed in (wrong arg). In this case, we don't need to set the key and wait for the active expire scan before deleting the key. Compared with previous changes: 1. If the key does not exist, previously we would set the key and wait for the active expire to delete it, so it is a set + del from the perspective of propaganda. Now we will no set the key and return, so it a NOP. 2. If the key exists, previously we woule set the key and wait for the active expire to delete it, so it is a set + del From the perspective of propaganda. Now we will delete it and return, so it is a del. A simple benchmark test: ``` ./src/valkey-benchmark -P 32 -c 100 -n 10000000 -r 1000000000 set __rand_int__ value exat 100 old: 252474.23, new: 829256.12 ``` Signed-off-by: Binbin <binloveplay1314@qq.com>
Configuration menu - View commit details
-
Copy full SHA for db5349d - Browse repository at this point
Copy the full SHA db5349dView commit details
Commits on Aug 8, 2024
-
adding deleteExpiredKeyFromOverwriteAndPropagate
Signed-off-by: Binbin <binloveplay1314@qq.com>
Configuration menu - View commit details
-
Copy full SHA for 4a742cb - Browse repository at this point
Copy the full SHA 4a742cbView commit details -
add back tick to milliseconds comment
Signed-off-by: Binbin <binloveplay1314@qq.com>
Configuration menu - View commit details
-
Copy full SHA for 33eb3b5 - Browse repository at this point
Copy the full SHA 33eb3b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73cde7a - Browse repository at this point
Copy the full SHA 73cde7aView commit details -
Signed-off-by: Binbin <binloveplay1314@qq.com>
Configuration menu - View commit details
-
Copy full SHA for e9e089b - Browse repository at this point
Copy the full SHA e9e089bView commit details
Commits on Aug 23, 2024
-
Merge remote-tracking branch 'upstream/unstable' into set_expire
Signed-off-by: Binbin <binloveplay1314@qq.com>
Configuration menu - View commit details
-
Copy full SHA for fef9cc9 - Browse repository at this point
Copy the full SHA fef9cc9View commit details -
Signed-off-by: Binbin <binloveplay1314@qq.com>
Configuration menu - View commit details
-
Copy full SHA for c7f74af - Browse repository at this point
Copy the full SHA c7f74afView commit details -
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Binbin <binloveplay1314@qq.com>
Configuration menu - View commit details
-
Copy full SHA for 58c086c - Browse repository at this point
Copy the full SHA 58c086cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.