Make runtest-cluster support --io-threads option #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In valkey-io#764, we add a --io-threads mode in test, but forgot to handle runtest-cluster, they are different framework. Currently runtest-cluster does not support tags, and we don't have plan to support it. And currently cluster tests does not have any io-threads tests, so this PR just align --io-threads option with valkey-io#764. Signed-off-by: Binbin <binloveplay1314@qq.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #933 +/- ##
============================================
+ Coverage 70.59% 70.62% +0.02%
============================================
Files 112 112
Lines 61512 61512
============================================
+ Hits 43427 43440 +13
+ Misses 18085 18072 -13 |
zuiderkwast
approved these changes
Aug 22, 2024
hwware
approved these changes
Aug 22, 2024
madolson
pushed a commit
that referenced
this pull request
Sep 2, 2024
In #764, we add a --io-threads mode in test, but forgot to handle runtest-cluster, they are different framework. Currently runtest-cluster does not support tags, and we don't have plan to support it. And currently cluster tests does not have any io-threads tests, so this PR just align --io-threads option with #764. Signed-off-by: Binbin <binloveplay1314@qq.com>
madolson
pushed a commit
that referenced
this pull request
Sep 3, 2024
In #764, we add a --io-threads mode in test, but forgot to handle runtest-cluster, they are different framework. Currently runtest-cluster does not support tags, and we don't have plan to support it. And currently cluster tests does not have any io-threads tests, so this PR just align --io-threads option with #764. Signed-off-by: Binbin <binloveplay1314@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #764, we add a --io-threads mode in test, but forgot
to handle runtest-cluster, they are different framework.
Currently runtest-cluster does not support tags, and we
don't have plan to support it. And currently cluster tests
does not have any io-threads tests, so this PR just align
--io-threads option with #764.