Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor return and goto statements #945

Merged
merged 15 commits into from
Oct 15, 2024
Merged

Refactor return and goto statements #945

merged 15 commits into from
Oct 15, 2024

Commits on Oct 10, 2024

  1. Refactor return and goto statements 

    Consolidate the cleanup of local variables to a single point within the method, ensuring proper resource management and preventing memory leaks or double-free issues.

Signed-off-by: naglera <anagler123@gmail.com>
    @naglera
    naglera committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    0bdda77 View commit details
    Browse the repository at this point in the history

  2. Refactore syncWithPrimary 

    Signed-off-by: naglera <anagler123@gmail.com>
    @naglera
    naglera committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    3731f72 View commit details
    Browse the repository at this point in the history

  3. refactor fullSyncWithPrimary using switch 

    Signed-off-by: naglera <anagler123@gmail.com>
    @naglera
    naglera committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    0ab52ce View commit details
    Browse the repository at this point in the history

  4. refactor serupMainConn using switch 

    Signed-off-by: naglera <anagler123@gmail.com>
    @naglera
    naglera committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    6806053 View commit details
    Browse the repository at this point in the history

  5. Fix comments 

    renaming and refactor

Signed-off-by: naglera <anagler123@gmail.com>
    @naglera
    naglera committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    0b8cd8f View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Ping Xie <pingxie@outlook.com>
Signed-off-by: Amit Nagler <58042354+naglera@users.noreply.github.com>
Signed-off-by: naglera <anagler123@gmail.com>
    @naglera @PingXie
    naglera and PingXie committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    84637f4 View commit details
    Browse the repository at this point in the history

  7. All worker functions should be stateless 

    all worker functions should be stateless
err should be type sds
endoffset response can be empty

Signed-off-by: naglera <anagler123@gmail.com>
    @naglera
    naglera committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    355708a View commit details
    Browse the repository at this point in the history

  8. Revert "Refactore syncWithPrimary" 

    This reverts commit 3c0933497fea5d84860d24f2864a9c14ffa991bf.

Signed-off-by: naglera <anagler123@gmail.com>
    @naglera
    naglera committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a5d66d2 View commit details
    Browse the repository at this point in the history

  9. Apply suggestions from code review 

    Co-authored-by: Ping Xie <pingxie@outlook.com>
Signed-off-by: Amit Nagler <58042354+naglera@users.noreply.github.com>
Signed-off-by: naglera <anagler123@gmail.com>
    @naglera @PingXie
    naglera and PingXie committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    e38603d View commit details
    Browse the repository at this point in the history

  10. Fix comments 

    Signed-off-by: naglera <anagler123@gmail.com>
    @naglera
    naglera committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    5707b19 View commit details
    Browse the repository at this point in the history

  11. Fix droped text 

    Signed-off-by: naglera <anagler123@gmail.com>
    @naglera
    naglera committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    031c07d View commit details
    Browse the repository at this point in the history

  12. Fix comments 

    Signed-off-by: naglera <anagler123@gmail.com>
    @naglera
    naglera committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    611feba View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Merge branch 'unstable' into goto-format 

    Signed-off-by: Amit Nagler <58042354+naglera@users.noreply.github.com>
    @naglera
    naglera authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    c508802 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Ping Xie <pingxie@outlook.com>
Signed-off-by: Amit Nagler <58042354+naglera@users.noreply.github.com>
Signed-off-by: naglera <anagler123@gmail.com>
    @naglera @PingXie
    naglera and PingXie committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    683b6ac View commit details
    Browse the repository at this point in the history

  3. Fix comments 

    Signed-off-by: naglera <anagler123@gmail.com>
    @naglera
    naglera committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    bbc498f View commit details
    Browse the repository at this point in the history