-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix replica unable trigger migration when it received CLUSTER SETSLOT in advance #981
Fix replica unable trigger migration when it received CLUSTER SETSLOT in advance #981
Commits on Sep 11, 2024
-
Fix replica unable trigger migration when it received CLUSTER SETSLOT…
… in advance When the primary and replica cluster-allow-replica-migration configuration items are different, the replica migration does not meet expectations. Originally: primary not allow, replica allow. In this case, the code will migrate the replica away, and the primary will keep as an empty primary. However, in valkey-io#970, we found a timing issue. For example, if the replica receives CLUSTER SETSLOT first and then receives the gossip change, it will not trigger the replica-migration. We perform replica migration explicitly in CLUSTER SETSLOT in this case. Signed-off-by: Binbin <binloveplay1314@qq.com>
Configuration menu - View commit details
-
Copy full SHA for 3aef09e - Browse repository at this point
Copy the full SHA 3aef09eView commit details -
Configuration menu - View commit details
-
Copy full SHA for cef953a - Browse repository at this point
Copy the full SHA cef953aView commit details
Commits on Sep 12, 2024
-
Merge remote-tracking branch 'upstream/unstable' into better_replica_…
…migration Signed-off-by: Binbin <binloveplay1314@qq.com>
Configuration menu - View commit details
-
Copy full SHA for 01fb912 - Browse repository at this point
Copy the full SHA 01fb912View commit details -
Signed-off-by: Binbin <binloveplay1314@qq.com>
Configuration menu - View commit details
-
Copy full SHA for 5603e98 - Browse repository at this point
Copy the full SHA 5603e98View commit details -
Co-authored-by: Ping Xie <pingxie@outlook.com> Signed-off-by: Binbin <binloveplay1314@qq.com>
Configuration menu - View commit details
-
Copy full SHA for 81f27c8 - Browse repository at this point
Copy the full SHA 81f27c8View commit details -
Signed-off-by: Binbin <binloveplay1314@qq.com>
Configuration menu - View commit details
-
Copy full SHA for 3df8cbe - Browse repository at this point
Copy the full SHA 3df8cbeView commit details -
Signed-off-by: Binbin <binloveplay1314@qq.com>
Configuration menu - View commit details
-
Copy full SHA for 87da96b - Browse repository at this point
Copy the full SHA 87da96bView commit details -
Signed-off-by: Binbin <binloveplay1314@qq.com>
Configuration menu - View commit details
-
Copy full SHA for 3f69a1c - Browse repository at this point
Copy the full SHA 3f69a1cView commit details -
Handle freeClientAsync did not respect full_sync_required
Signed-off-by: Binbin <binloveplay1314@qq.com>
Configuration menu - View commit details
-
Copy full SHA for fc3f0c3 - Browse repository at this point
Copy the full SHA fc3f0c3View commit details
Commits on Sep 13, 2024
-
Apply suggestions from code review
Co-authored-by: Ping Xie <pingxie@outlook.com> Signed-off-by: Binbin <binloveplay1314@qq.com>
Configuration menu - View commit details
-
Copy full SHA for 8896c0e - Browse repository at this point
Copy the full SHA 8896c0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f9abd82 - Browse repository at this point
Copy the full SHA f9abd82View commit details