Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the disabled state #225

Merged
merged 2 commits into from
Jul 19, 2016
Merged

fixed the disabled state #225

merged 2 commits into from
Jul 19, 2016

Conversation

linusbrolin
Copy link
Contributor

The disabled state wasn't working, due to the boolean used in the template only being a setter, not a getter.
Replaced with the private _disabled boolean instead.

@valorkin
Copy link
Member

valorkin commented Jun 1, 2016

@linusbrolin can not agree,
can you just add getter for disabled?
because switching to _disabled removes call to .hideOptions

@linusbrolin
Copy link
Contributor Author

Sure.
I just thought that the public disabled should only be a setter.
But if having a public getter is no problem, then I'll do that instead, no problem. :)

@linusbrolin
Copy link
Contributor Author

status on this?

@valorkin
Copy link
Member

Thanks, sorry for delay

@valorkin valorkin merged commit 388506f into development Jul 19, 2016
@valorkin valorkin deleted the disabled-state-fix branch September 8, 2016 11:37
@valorkin valorkin restored the disabled-state-fix branch September 8, 2016 11:37
@valorkin valorkin deleted the disabled-state-fix branch September 8, 2016 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants