Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(popover): don't show popover if content is undefined #1504

Closed
serddmitry opened this issue Jan 16, 2017 · 4 comments
Closed

feat(popover): don't show popover if content is undefined #1504

serddmitry opened this issue Jan 16, 2017 · 4 comments

Comments

@serddmitry
Copy link

serddmitry commented Jan 16, 2017

UPDATE: it should be like with tooltips, if a content is not defined, it should be displayed

In our app we show popovers if the popover content is present, which is not always the case.
Would be cool to be able to disable popover through a property. As a workaround, I'm using 2 *ngIf - one with popover and one without.

@valorkin
Copy link
Member

you can control it via [isOpen] popover property

@ersimont
Copy link

Either I don't understand the request or the response. Let me explain my situation, which I thought matches what @serddmitry was requesting:

I have a number of components displayed using *ngFor. Some of them should have popovers, some should not, depending on their value (let's call that value item.popoverText). Currently if popoverText is undefined, the element has a tiny blank popover. Is there a way to disable that, so there is no popover at all in such a case?

@valorkin
Copy link
Member

aha, ok
@ersimont
it should be like with tooltips, if a content is not defined, it should be displayed

@valorkin valorkin reopened this Aug 23, 2017
@valorkin valorkin changed the title feat(popover): disable feat(popover): don't show popover if content is undefined Aug 23, 2017
valorkin pushed a commit that referenced this issue Oct 20, 2017
* feat(popover): don't show popover if content is undefined, #1504

* Update popover.directive.ts
@RohanGovande
Copy link

We are currently using popover version 1.6.3 and can't update it fr some other dependencies, do we have any alternative for this that would work in older version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants