Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comp(sortable) improvements #1592

Closed

Conversation

Le0Michine
Copy link
Contributor

@Le0Michine Le0Michine commented Feb 2, 2017

touch support
directives (allows to make such things as tables or other complicated templates sortable)
limitations for transferring items between containers can be set
bux fixes (e.g. selected item wasn't unselected if was dropped outside container)

@Le0Michine
Copy link
Contributor Author

could affect #1554

@codecov-io
Copy link

codecov-io commented Feb 2, 2017

Codecov Report

Merging #1592 into development will increase coverage by 0.72%.

@@               Coverage Diff               @@
##           development    #1592      +/-   ##
===============================================
+ Coverage        84.84%   85.56%   +0.72%     
===============================================
  Files               85       92       +7     
  Lines             2323     2543     +220     
  Branches           299      328      +29     
===============================================
+ Hits              1971     2176     +205     
- Misses             252      262      +10     
- Partials           100      105       +5
Impacted Files Coverage Δ
...sortable/directives/draggable-element.directive.ts 100% <100%> (ø)
src/sortable/components/index.ts 100% <100%> (ø)
src/sortable/point.helper.ts 100% <100%> (ø)
src/sortable/sortable.module.ts 100% <100%> (ø)
src/sortable/services/index.ts 100% <100%> (ø)
src/sortable/index.ts 100% <100%> (ø)
src/sortable/directives/index.ts 100% <100%> (ø)
src/sortable/array.helper.ts 100% <100%> (ø)
src/sortable/directives/drop-zone.directive.ts 90.51% <90.51%> (ø)
src/sortable/services/drag-and-drop.service.ts 96% <96%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cdb4e5...9aedcd7. Read the comment docs.

@Le0Michine Le0Michine changed the title feat(sortable) improvements comp(sortable) improvements Feb 5, 2017
@Le0Michine Le0Michine force-pushed the sortable-2.0 branch 2 times, most recently from 8ebbac3 to f452625 Compare February 6, 2017 10:36
 added new functionality (directives, ability to disable exact items, support for touch devices)
@Le0Michine
Copy link
Contributor Author

@valorkin hey, it was created more when 3 weeks ago :)

@valorkin
Copy link
Member

I am here, horey

@doug62
Copy link

doug62 commented Apr 20, 2017

When will this be merged?

@DanniB
Copy link

DanniB commented Jun 8, 2017

Is it possible to limit the array size? I would like to assign a number of m tones to n modi, where m>n.

@valorkin valorkin removed their assignment Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants