Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown,rating,typeahead): remove global in order to be usable … #1734

Merged
merged 2 commits into from
Mar 10, 2017

Conversation

karlhaas
Copy link
Contributor

…with systemjs and aot

@valorkin
Copy link
Member

valorkin commented Mar 10, 2017

and here https://github.com/valor-software/ng2-bootstrap/pull/1734/files#diff-a4f2d9fe15a93898cef7b2fcb7adc4dbL45
try to replace with Event

and all other places

@karlhaas
Copy link
Contributor Author

why?

@codecov-io
Copy link

codecov-io commented Mar 10, 2017

Codecov Report

Merging #1734 into development will decrease coverage by 0.03%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           development    #1734      +/-   ##
===============================================
- Coverage        85.44%   85.41%   -0.04%     
===============================================
  Files               85       85              
  Lines             2295     2290       -5     
  Branches           300      300              
===============================================
- Hits              1961     1956       -5     
  Misses             235      235              
  Partials            99       99
Impacted Files Coverage Δ
src/typeahead/typeahead.directive.ts 76.27% <ø> (-0.14%)
src/rating/rating.component.ts 80.3% <ø> (-0.3%)
src/dropdown/dropdown.service.ts 82% <100%> (-0.7%)
src/dropdown/dropdown-toggle.directive.ts 100% <100%> (ø)
src/pagination/pagination.component.ts 87.2% <100%> (ø)
src/pagination/pager.component.ts 80.8% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27a0229...685ddfd. Read the comment docs.

@valorkin
Copy link
Member

If not replace with Event it will throw an error at universal

@valorkin valorkin merged commit 4a7719b into valor-software:development Mar 10, 2017
@valorkin
Copy link
Member

Thanks

@karlhaas
Copy link
Contributor Author

@valorkin could you please provide a new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants