-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Popover focus on Mac OS fix #2031
Conversation
Codecov Report
@@ Coverage Diff @@
## development #2031 +/- ##
===============================================
- Coverage 87.16% 87.05% -0.11%
===============================================
Files 85 85
Lines 2259 2263 +4
Branches 292 292
===============================================
+ Hits 1969 1970 +1
- Misses 187 190 +3
Partials 103 103
Continue to review full report at Codecov.
|
@valorkin What's wrong ? |
why popover needs focus? |
We need to hide it when clicking on other part of page. To be able to have blur event, we need focus before (like all Windows browser does but not some OSX browers). With this correction, it works like base bootstrap component (jquery). |
Tested, looks good |
Thanks for PR! |
fix(popover): no focus on button on Mac OS valor-software#1795 (valor-software#2031)
#1795