feat(timepicker): added test plan #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valorkin
force-pushed
the
feat-timepicker
branch
from
e22373d to
eb31cae
Compare
Codecov Report
@@ Coverage Diff @@
## feat-timepicker #2127 +/- ##
====================================================
- Coverage 86.15% 41.97% -44.19%
====================================================
Files 94 95 +1
Lines 2666 2623 -43
Branches 359 347 -12
====================================================
- Hits 2297 1101 -1196
- Misses 243 1516 +1273
+ Partials 126 6 -120
Continue to review full report at Codecov.
|
artemvfrolov
force-pushed
the
test-plan
branch
4 times, most recently
from
51f424f to
b22c1f6
Compare
artemvfrolov
force-pushed
the
test-plan
branch
6 times, most recently
from
f7f3566 to
a19ec2c
Compare
artemvfrolov
force-pushed
the
test-plan
branch
6 times, most recently
from
563fd15 to
8854dc9
Compare
IlyaSurmay
force-pushed
the
feat-timepicker
branch
from
4f85f8e to
083e8e8
Compare
artemvfrolov
force-pushed
the
test-plan
branch
3 times, most recently
from
8e89636 to
f584586
Compare
SergeyKuryatnick
suggested changes
Jul 11, 2017
| } | ||
|
|
||
| describe('Runtime coverage. Utils: Timepicker', () => { | ||
| it('should is no value', () => { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| return fixture.debugElement.queryAll(By.css(selector)); | ||
| } | ||
|
|
||
| function testTime(hours?: number, minutes?: number, seconds?: number) { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
|
||
| it('should changeHours', () => { | ||
| context.changeHours(3); | ||
| // поле часы и минуты отображаются |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| // проверить данные в поле минуты корректные данные с неполным значением | ||
| it('should validate the data in the minutes input with valid data with half value', () => { | ||
| component.writeValue(testTime(0,2,0)); | ||
| fixture.detectChanges(); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Try not to use |
artemvfrolov
force-pushed
the
test-plan
branch
2 times, most recently
from
6c91b71 to
04cedb4
Compare
|
Tests are failed. recheck pls. |
SergeyKuryatnick
approved these changes
Jul 14, 2017
valorkin
added a commit
that referenced
this pull request
Jul 19, 2017
fixes #2036 fixes #1981 ( + min max demo ) fixes #1973 close #1957 ( + seconds demo ) fixes #1935 fixes #1672 feat #1007 added keyboard and mousewheel support fixes #962 fixes #793 fixes #173 fixes #1271 added custom validation demo fixes #1539 bs4 fixes #1253 if input is invalid * feat(timepicker): new timepicker implementation * feat(timepicker): new timepicker implementation testing * chore(timepicker): removed old timepicker implementation * chore(mini-ngrx): added ngrx licence * fix(timepicker): fix seconds * fix(timepicker): fix custom validation demo * fix(tests): fix tests & aot errors * fix(timepicker): min max restrictions * fix(timepicker): min max checks * feat(timepicker): add inputs validation (#2187) * feat(timepicker): add inputs validation * fix(timepicker): add isPM support * feat(timepicker): add isValid output * feat(timepicker): added test plan (#2127) * fix(timepicker): fix ngModelChange demo * fix(test): fix unit tests * docs(timepicker): fix docs conflict, add isValid description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.